Closed
Bug 1730507
Opened 3 years ago
Closed 3 years ago
Objects allocated from panel's document aren't correctly tracked by leak scripts
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(firefox94 fixed)
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
(Whiteboard: dt-perf-stability-triage)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1727837 introduced some helpers to track leaks and print their allocation sites.
But as reported in https://phabricator.services.mozilla.com/D123834#4066130,
the javascript objects allocated from Browser Loader's modules and/or any toolbox's panel global are missing their allocation sites.
This is because the allocation tracker is ignoring the related globals.
|
Assignee | |
Comment 1•3 years ago
|
||
We were correctly tracking the top toolbox document, while ignoring any of its children document,
which are all having about:blank location when processed by the allocation tracker.
While I can't easily add coverage for this particular code,
I'm adding some more coverage around the leak scripts.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4eeb822c9a23
[devtools] Track globals of panel's documents from the leak scripts. r=jdescottes
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•