Closed Bug 1730798 Opened 3 years ago Closed 3 years ago

Port bug 1713605 - Use NSS only on socket thread in CertVerifier::VerifySSLServerCert

Categories

(Thunderbird :: Upstream Synchronization, task)

Tracking

(thunderbird_esr91 unaffected)

RESOLVED FIXED
94 Branch
Tracking Status
thunderbird_esr91 --- unaffected

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(2 files)

No description provided.
Target Milestone: --- → 94 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/c894a3a6a723
Port bug 1713605 - Use NSS only on socket thread in CertVerifier::VerifySSLServerCert. r=BenC

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Geoff - that patch introduces some leaks. Please see the comments I left on the phabricator revision.

Flags: needinfo?(geoff)

Thanks for checking. This is what happens when you get me writing C++ code to fix the build. :-)

Status: RESOLVED → REOPENED
Flags: needinfo?(geoff)
Resolution: FIXED → ---

(In reply to Dana Keeler (she/her) (use needinfo) (:keeler for reviews) from comment #3)

Geoff - that patch introduces some leaks. Please see the comments I left on the phabricator revision.

Whoops, that was my review, so thanks Dana! The idl getCert() definition confused me. I'm glad someone knows what they're doing :-)

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/dbe181b3fcb2
follow-up - Stop leaking CERTCertificates. r=benc

Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: