Closed Bug 1731047 Opened 3 years ago Closed 3 years ago

Disabling smooth scrolling does not work for keyboard scrolling when msdPhysics is enabled.

Categories

(Core :: Panning and Zooming, defect)

Firefox 83
defect

Tracking

()

VERIFIED FIXED
94 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- wontfix
firefox92 --- wontfix
firefox93 --- wontfix
firefox94 --- verified

People

(Reporter: ke5trel, Assigned: tnikkel)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STR:

  1. Set general.smoothScroll = false and general.smoothScroll.msdPhysics.enabled = true.
  2. Press the up/down arrow, page up/down or home/end keys to scroll the page.

Expected:

Scrolls in discrete steps without smoothing.

Actual:

Scrolls smoothly despite smooth scrolling being disabled.

Works as expected with apz.force_disable_desktop_zooming_scrollbars = true.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cab81767be70469b780cd372ff463df59c2264e0&tochange=32a2e59ab7260118d8d5f430e503967fad6993cf

Regressed by Bug 1657822.

What is the reason to have those prefs set that way? Seems contradictory?

Main thread scrolls already respect it, but when we moved these to be done by apz we evidently overlooked this.

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED

Users may want to customize scroll settings to their liking and then toggle smooth scrolling on and off as they see fit from about:preferences. They could have also enabled msdPhysics a long time ago and forgotten about it, then just assumed that keyboard scrolling does not abide by the smooth scrolling setting.

Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d45da894beb9 Respect general.smoothScroll = false even if general.smoothScroll.msdPhysics.enabled = true. r=botond
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Flags: qe-verify+

Verified with 94.0b2 on Win10, Ubuntu 16x32, scrolling is not smoothed down.

Based on Comment 6, I'm marking this issue as Verified Fixed.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: