Use SmallValueHolder for more frame properties, now that frame properties have 64 bits of storage even on 32-bit systems
Categories
(Core :: Layout, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
In bug 1591366, we're changing our internal frame-property representation to consistently use 64 bits of storage for each property (rather than using a void* as the internal storage, which only gives us 32 bits on 32-bit systems)
Now that we've got 64 bits, I suspect there are some frame properties (of size between 32bits and 64bits) which we can convert to use SmallValueHolder, to be stored directly as the frame property value instead of a pointed-to external value.
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
This frame property's type is small enough to fit directly in the property
table's 64-byte slot; so, this patch makes us store the data directly there
(rather than allocating it externally and storing a pointer in the table).
This patch shouldn't impact behavior at all.
|
|
Assignee | |
Comment 2•3 years ago
|
||
This frame property's type is small enough to fit directly in the property
table's 64-byte slot; so, this patch makes us store the data directly there
(rather than allocating it externally and storing a pointer in the table).
This patch shouldn't impact behavior at all.
Depends on D126031
|
|
Assignee | |
Comment 3•3 years ago
|
||
(bug 1591366 -- whose 'part 1' we depend on here -- just re-landed. Once it's clear that it has stuck, I'll go ahead and land this.)
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/149576c5378b
https://hg.mozilla.org/mozilla-central/rev/efaac9f0c316
Description
•