Open
Bug 1731363
Opened 3 years ago
Updated 3 years ago
Merge vendored-package "requirements.in" with centralized dependency system
Categories
(Firefox Build System :: Mach Core, enhancement, P3)
Firefox Build System
Mach Core
Tracking
(Not tracked)
NEW
People
(Reporter: mhentges, Unassigned)
References
Details
I'm guessing this would look something like:
- Vendored package requirements would be placed in virtualenv requirements files (
<venv>_virtualenv_packages.txt
) - When vendoring, all virtualenv requirements files will be read, and a version of each vendored package that satisfies all requirements will be vendored
- A
requirements.txt
file will still be generated inthird_party/python/requirements.txt
- The
sys.path
modifications required will be automatically generated for the vendored requirement and its dependencies.
Why?
Three reasons:
- Right now, it's hard to keep track of where to specify a dependency ("do I put it in a virtualenv requirement file, or in
third_party/python/requirements.in
?") - Don't forget to add the vendored package's path to
<venv>_virtualenv_packages.txt
! - As of bug 1730712, system packages are more-frequently in-scope. However, they aren't currently asserted to be the same version as the in-tree variants.
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Priority: -- → P3
You need to log in
before you can comment on or make changes to this bug.
Description
•