xdg-desktop-portal 1.10.0 breaks pipewire support
Categories
(Core :: WebRTC, defect)
Tracking
()
People
(Reporter: heftig, Assigned: heftig)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
See a fix for this issue in OBS: https://github.com/obsproject/obs-studio/commit/ef0540c0d7df64b6cb148c80d566281a4ff3ba5c
In the response for the session create request, the type for the "session_handle"
field was changed from "s"
to "o"
to match the documentation. Unfortunately, this now causes clients that do typechecks to fail.
Assignee | ||
Comment 1•3 years ago
|
||
Since xdg-desktop-portal 1.10.0, the type is "o" (an object path string)
instead of "s" (a normal string). g_variant_lookup fails if the type
doesn't match exactly, even though both are strings.
Use g_variant_lookup_value to get the field value, telling it not to
typecheck. Use g_variant_dup_string to extract the string, which doesn't
care about the exact type, so this code should work with all versions of
xdg-desktop-portal.
Following a similar fix to OBS, see
https://github.com/obsproject/obs-studio/commit/ef0540c0d7df.
Updated•3 years ago
|
Comment 2•3 years ago
|
||
Comment 3•3 years ago
|
||
Upstream MR: https://webrtc-review.googlesource.com/c/src/+/232329 (but that's not allowed URL for a see-also...).
Assignee | ||
Comment 4•3 years ago
|
||
Try build WFM, xdg-desktop-portal 1.10.0, Arch Linux.
Comment 5•3 years ago
|
||
Martin, you may want to forward port this on Fedora >=35
Comment 8•3 years ago
|
||
bugherder |
Comment 9•3 years ago
|
||
Could this be backported? It'll break screen sharing for many of us on Wayland sessions. Not updating xdg-desktop-portal is not a realistic workaround on a rolling release distro.
Comment 10•3 years ago
|
||
Comment on attachment 9241975 [details]
Bug 1731495 - Don't typecheck the pipewire session_handle. r?rmader
Beta/Release Uplift Approval Request
- User impact if declined: Users with a recent version of xdg-desktop-portal (Arch, beta versions of Fedora or Ubuntu) will have broken screen sharing on Wayland.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Only Wayland screen sharing is affected, equivalent patches are used in other software such as upstream Chrome and OBS Studio.
- String changes made/needed:
Comment 11•3 years ago
|
||
Comment on attachment 9241975 [details]
Bug 1731495 - Don't typecheck the pipewire session_handle. r?rmader
The impact is important for the users affected and we don't officially ship Wayland ourselves so that seems not risky, approved for 93 beta 8, thanks.
Comment 12•3 years ago
|
||
bugherder uplift |
Description
•