Closed
Bug 1731554
Opened 3 years ago
Closed 3 years ago
TargetActorMixin interface is never destroyed
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(firefox94 fixed)
RESOLVED
FIXED
94 Branch
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
TargetActorMixin.destroy is never called:
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/target-actor-mixin.js#204-210
(see codecoverage data)
Because of this, we never clear StyleSheetManager and ultimately keep the target actor in memory...
This destroy method is never called because the subclass (BrowsingContextTargetActorPrototype) is also implementing a destroy method and would override it over here:
https://searchfox.org/mozilla-central/rev/13378066961f195595822d4f543c8ac5b7f46490/devtools/server/actors/targets/target-actor-mixin.js#214-217
We should use the same pattern as initialize
.
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cab8432cdadd
[devtools] Destroy the TargetActorMixin interface. r=nchevobbe
Comment 3•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•