Theme notification badges, tab throbber, and attention color
Categories
(Firefox :: Theme, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
(Whiteboard: [fidefe-theme])
Attachments
(2 files)
The Figma spec calls for app menu badges, tab throbber, and the attention color to be themed. The attention color is the color used primarily in the bookmarks star and download icon.
One tricky part of this bug will be that the "Balanced" themes call for two attention colors: one for light backgrounds (bookmarks star in the address bar, tab throbber in the active tab), and one for dark backgrounds (download icon, app menu notification). We'll need to refactor some CSS to enable this.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
There are a few slight changes to other properties. These are ridealongs, and a result of UX updating the colors in the Figma spec. Those changes are included in the Figma export, so they get pulled in when I create new manifests with my script. Here are the script changes for this bug: https://github.com/htwyford/create-theme-script/pull/2
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 5•3 years ago
|
||
bugherder |
Comment 6•3 years ago
|
||
Re-opening the issue, because as mentioned, for all balanced themes seem to cause an issue.
More specific, the bookmark icon from the address bar and the bookmark icon from the address bar drop-down (search shortcuts section), have different colors. Here are the steps:
- Launch Firefox.
- Enable any balanced theme.
- Go to a website and bookmark it.
- Click on the address bar in order to expand it and compare the bookmark icons.
AR: Bookmark icon has different colors.
ER: Bookmark icon has the same color.
Please note that there is also the issue of visibility in the current implementation. Hovering over the bookmark shortcut in the address bar dropdown makes the icon barely visible.
Please see the attached screenshots for more details.
Updated•3 years ago
|
Assignee | ||
Comment 7•3 years ago
|
||
Filed in bug 1734646.
Description
•