Closed
Bug 1732268
Opened 3 years ago
Closed 3 years ago
Get rid of misleading null-checks in nsLineIterator initialization
Categories
(Core :: Layout: Block and Inline, defect)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
94 Branch
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
new
is infallible by default, so the null-checks are redundant, and callers don't need to check for failure.
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Updated•3 years ago
|
Attachment #9242649 -
Attachment description: Bug 1732268 - Remove redundant failure-checks from nsLineIterator initialization, as it uses infallible allocation, so that nsBlockFrame::GetLineIterator is clearly infallible. r=#layout-reviewers → Bug 1732268 - Remove redundant failure-checks from nsLineIterator initialization, as it uses infallible allocation. r=#layout-reviewers
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/132a81168ee1
Remove redundant failure-checks from nsLineIterator initialization, as it uses infallible allocation. r=dholbert
Comment 3•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•