Closed Bug 1732405 Opened 3 years ago Closed 3 years ago

Location bar text selection is barely visible in dark mode on macOS

Categories

(Core :: Widget: Cocoa, defect)

Desktop
macOS
defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- wontfix
firefox93 --- wontfix
firefox94 --- wontfix
firefox95 --- wontfix

People

(Reporter: bytesized, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Attached image selection problem.png (deleted) —

If you look at the attached image, you might be able to barely see that half of the text is selected. The selection is the path part of the URL (/en-US/privacy/firefox/). The rest of the text is not selected. However, I can only just barely see the text selection.

This has been like this for some time on my computer. Since it has started happening, I have installed OS updates, installed Firefox updates, and rebooted. But the problem persists. At first, I assumed that this was a problem with my configuration. But the attached screenshot is actually from a completely fresh profile.

This is on an up-to-date macbook pro. The only display settings I can think of that I have configured are that I have Dark Mode enabled, the Reduce Transparency option is enabled, and my accent color is Graphite. I tried changing these, but it didn't seem to have an effect. Though I didn't restart the browser. I'm not sure if that is relevant. If I change the Firefox theme to "Light", I can see the selection just fine. But not with the "Dark" theme, or the "System theme".

Just to be sure, I just tried changing my accent color and rebooting. This does not seem to have affected the problem.

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)
Severity: -- → S2
Flags: needinfo?(dao+bmo)
OS: Unspecified → macOS
Priority: -- → P2
Hardware: Unspecified → Desktop
Summary: Location bar text selection is barely visible → Location bar text selection is barely visible in dark mode on macOS
QA Whiteboard: [qa-regression-triage]

I can reproduce this issue on my macOS Big Sur 11.6 on the latest Nightly 95.0a1, but only when playing with the "Highlight color" options (from System Preferences -> General) - I select "Other" and then choose a similar color with the one a focused Address Bar has.

Kirk, could you please check if you are encountering this issue in the same conditions as me?

Flags: needinfo?(ksteuber)

Ah! Yes, changing the highlight color does seem to fix this. That's weird, I really don't remember changing that setting. And I certainly don't remember picking a custom color from a chooser. But changing to a different Highlight Color does seem to solve the problem.

Flags: needinfo?(ksteuber)

Harry, what would be the expected result here?

Mozregression revealed Bug 1712215 to be the regressor of this issue.
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c10a52874ea2370e60c3f04cd079f002d3780497&tochange=f7a108e738eedbb97eb84f28bffa518e1c7484a6

Has Regression Range: --- → yes
QA Whiteboard: [qa-regression-triage]
Flags: needinfo?(htwyford)
Regressed by: 1712215

(In reply to Simona Badau from comment #5)

Mozregression revealed Bug 1712215 to be the regressor of this issue.
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c10a52874ea2370e60c3f04cd079f002d3780497&tochange=f7a108e738eedbb97eb84f28bffa518e1c7484a6

That doesn't seem right. Bug 1712215 would only affect the new tab page which is completely separate from the browser UI where the address bar is implemented. Could you please check again?

Flags: needinfo?(simona.marcu)

(In reply to Dão Gottwald [::dao] from comment #6)

That doesn't seem right. Bug 1712215 would only affect the new tab page which is completely separate from the browser UI where the address bar is implemented. Could you please check again?

Yes sure.
Narrowed regression window to:
Last good revision: b8b54a4990d7e778b82909a871e92031a4bc649d
First bad revision: 4b3932f9c4f5d9572da2f0232375474133191500
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b8b54a4990d7e778b82909a871e92031a4bc649d&tochange=4b3932f9c4f5d9572da2f0232375474133191500

Flags: needinfo?(simona.marcu)
No longer regressed by: 1712215

That makes more sense. It's triggered by bug 1715619, but that was just a pref flip bug. The selection color issues were addressed in bugs 1700294 and 1703892. Kirk and Simona, to be clear, is there only a contrast issue here when selecting the "Other" highlight color and setting it to something similar to the address bar background in Firefox?

Flags: needinfo?(simona.marcu)
Flags: needinfo?(ksteuber)
Flags: needinfo?(htwyford)

The whole thing seems very odd to me. I have no recollection of setting the highlight color to "Other", and definitely no recollection of picking a color from the color chooser. I like the "Graphite" color scheme so I may have set the highlight color to Graphite, but I really don't think I would have intentionally set it to "Other". Maybe I just mis-clicked? I'm not really sure. But I can say that I no longer experience the issue now that I've set my highlight color to "Graphite".

Flags: needinfo?(ksteuber)

(In reply to Harry Twyford [:harry] from comment #8)

That makes more sense. It's triggered by bug 1715619, but that was just a pref flip bug. The selection color issues were addressed in bugs 1700294 and 1703892. Kirk and Simona, to be clear, is there only a contrast issue here when selecting the "Other" highlight color and setting it to something similar to the address bar background in Firefox?

Yes, I have only seen this while selecting the Other option for the Highlight Color. I've also taken a screencast, that can be seen here.

Flags: needinfo?(simona.marcu)
Severity: S2 → --
Component: Theme → Widget: Cocoa
Priority: P2 → --
Product: Firefox → Core
Regressed by: 1715619

Okay, I'm going to close this WONTFIX. It will always be possible to set the highlight color to be the same as the address bar background. I don't think a workaround in that case is necessary or even wanted. If it turns out that a Firefox or macOS bug is causing the highlight color to be set to Other unexpectedly, as has appeared to have happened in Kirk's case, we can reopen this and think of a solution.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: