pass down "transform to ancestor scale" to child processes and use it displayport/apz related places
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(6 files)
|
Assignee | |
Comment 1•3 years ago
|
||
This is the conclusion we came to after some discussion.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
In bug 1731929 we added this value, here we give it the value we want for child processes. I think the code comments should explain it.
Depends on D126628
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
This else should only get hit if we can't get the docshell or content viewer from the prescontext, which should only be unusual setting up or tearing down timeframes, so it doesn't matter too much.
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D126659
|
|
Assignee | |
Comment 5•3 years ago
|
||
Depends on D126660
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 6•3 years ago
|
||
It is unused, it accidentally slipped in in bug 1731929 but was never used.
Depends on D126628
|
|
||
Updated•3 years ago
|
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/832e46a88922 Update a comment on FrameMetrics::mCumulativeResolution. r=botond https://hg.mozilla.org/integration/autoland/rev/fcba9b334513 Remove PixelCastJustification::TransformToAncestorScaleIsStoredUntyped. r=botond https://hg.mozilla.org/integration/autoland/rev/ea1f49e03b8b Pass down transform to ancestor scale to child processes. r=botond https://hg.mozilla.org/integration/autoland/rev/d39165de0a11 Use ancestor process transform to ancestor scale in nsLayoutUtils::CalculateBoundingCompositionSize. r=botond https://hg.mozilla.org/integration/autoland/rev/e3712c7214b8 Make ComputeDisplayportScale use the ancestor process transform to ancestor scale. r=botond https://hg.mozilla.org/integration/autoland/rev/9e95cc6419d7 Make GetDisplayPortFromMarginsData use ancestor process transform to ancestor scale. r=botond
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/832e46a88922
https://hg.mozilla.org/mozilla-central/rev/fcba9b334513
https://hg.mozilla.org/mozilla-central/rev/ea1f49e03b8b
https://hg.mozilla.org/mozilla-central/rev/d39165de0a11
https://hg.mozilla.org/mozilla-central/rev/e3712c7214b8
https://hg.mozilla.org/mozilla-central/rev/9e95cc6419d7
|
|
||
Comment 9•3 years ago
|
||
Timothy, does this bug affect both Fission and e10s users? Should your fix be uplifted to Beta 94 (for the Fission MVP release in Firefox 94)?
|
|
Assignee | |
Comment 10•3 years ago
|
||
Similar to bug 1732660, comment 6. These patches were ready right on the soft freeze deadline and I opted to wait to land them, so I don't think we need to uplift them.
|
|
||
Comment 11•3 years ago
|
||
(In reply to Timothy Nikkel (:tnikkel) from comment #10)
Similar to bug 1732660, comment 6. These patches were ready right on the soft freeze deadline and I opted to wait to land them, so I don't think we need to uplift them.
SGTM. In that case, I will set status-firefox94=wontfix.
Description
•