Request a "mach create-mach-environment" if Mach venv out-of-date
Categories
(Firefox Build System :: Mach Core, enhancement)
Tracking
(firefox96 fixed)
Tracking | Status | |
---|---|---|
firefox96 | --- | fixed |
People
(Reporter: mhentges, Assigned: mhentges)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Note: currently, mach_venv.up_to_date()
takes ~500ms to run, which is a lot for every Mach invocation. Let's land this after performance there improves (probably by removing the pip list
call, using hashes instead, etc).
Assignee | ||
Comment 1•3 years ago
|
||
As we leverage the Mach environment more, it becomes increasingly
important that it isn't out-of-date on developer machines.
Add an up_to_date()
check during Mach initialization.
To minimize the cost to startup, I'm skipping the "pip list" check.
This change required moving virtualenv
from mozbuild
to mach
to
make it available during the early stage of Mach init.
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 2•3 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mhentges, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 3•3 years ago
|
||
Probably landing this today, it was a dependent on the stack :)
Comment 5•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Updated•3 years ago
|
Description
•