Closed Bug 1733238 Opened 3 years ago Closed 3 years ago

Fire ANIMATED state change events

Categories

(Core :: Disability Access APIs, task, P3)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

If an image's source changes to/from an animated gif we need to fire an ANIMATED state change. I don't know if listening for a src attribute change is enough here since it might still need to load the image to know if it is animated. A better indicator is nsAccessibilityService::NotifyOfImageSizeAvailable, but we will need to store the previous state for that.

Changing severity to S3 because this is ongoing cache the world work that does not affect current users.

Severity: -- → S3
Type: defect → task
Priority: -- → P3
Assignee: nobody → eitan
Status: NEW → ASSIGNED

Use imgINotificationObserver to get notified of size availability.
Layout uses an observer to wait for this too. Our observer is notified
after layout so we should have bounds by then.

We need to store the request status because we get a lot of "replayed"
status changes that would cause chatty and wrong state change events
when the accessible is first created and bound to parent.

We can use that status for both INVISIBLE and ANIMATED states in
NativeState.

Depends on D127718

Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c132ebfabb2 P1: Add test for late-loading image and INVISIBLE change. r=Jamie https://hg.mozilla.org/integration/autoland/rev/352c6a7ae5cd P2: Make ImageAccessible an imgINotificationObserver. r=Jamie https://hg.mozilla.org/integration/autoland/rev/7753b03a092a P3: Add ANIMATED state change notification to ImageAccessible. r=Jamie

Backed out for causing hybrid build bustages

Flags: needinfo?(eitan)
Attachment #9244630 - Attachment description: Bug 1733238 - P1: Add test for late-loading image and INVISIBLE change. r?Jamie → Bug 1733238 - P1: Add test for late-loading image and INVISIBLE change. r=Jamie
Attachment #9244631 - Attachment description: Bug 1733238 - P2: Make ImageAccessible an imgINotificationObserver. r?Jamie → Bug 1733238 - P2: Make ImageAccessible an imgINotificationObserver. r=Jamie
Attachment #9244632 - Attachment description: Bug 1733238 - P3: Add ANIMATED state change notification to ImageAccessible. r?Jamie → Bug 1733238 - P3: Add ANIMATED state change notification to ImageAccessible. r=Jamie
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c5d218eb6acb P1: Add test for late-loading image and INVISIBLE change. r=Jamie https://hg.mozilla.org/integration/autoland/rev/910aebecda65 P2: Make ImageAccessible an imgINotificationObserver. r=Jamie https://hg.mozilla.org/integration/autoland/rev/af8436178a49 P3: Add ANIMATED state change notification to ImageAccessible. r=Jamie
Flags: needinfo?(eitan)
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30572d7dd9dd P1: Add test for late-loading image and INVISIBLE change. r=Jamie https://hg.mozilla.org/integration/autoland/rev/0133dadaf3eb P2: Make ImageAccessible an imgINotificationObserver. r=Jamie https://hg.mozilla.org/integration/autoland/rev/10f92eac8bc7 P3: Add ANIMATED state change notification to ImageAccessible. r=Jamie
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: