Closed Bug 1733243 Opened 3 years ago Closed 3 years ago

Fire MULTISELECTABLE/EXTSELECTABLE state change events

Categories

(Core :: Disability Access APIs, task, P3)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

We need to add aria-multiselectable to LocalAccessible::AttributeChangesState and multiple to HTMLSelectListAccessible::AttributeChangesState.

Changing severity to S3 because this is ongoing cache the world work that does not affect current users.

Severity: -- → S3
Type: defect → task
Priority: -- → P3

We were force recreating accessibles when their aria-multiselectable
attribute changed. This was perhaps done in the past because of
percieved limitations in COM, or the implementing class was different.

This isn't the case anymore. We should instead fire state change events
when aria-multiselectable changes.

Assignee: nobody → eitan
Status: NEW → ASSIGNED

If a <select> element with a default size or size of 1 gets the
multiple attribute it will change from a combobox button to an
embedded listbox. Similarly, if a select's size is set to something
larger than 1 it will convert from a combobox button to a listbox.

We should recreate the select's subtree because the
implementing classes are different for those two cases.

Depends on D128275

If a select's size is greater than 1 it won't be recreated when multiple
is added or removed. State change events should be fired in that case.

Depends on D128276

Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/256ac233fc22 P1: Don't recreate aria-multiselectable changes, fire state change instead. r=morgan https://hg.mozilla.org/integration/autoland/rev/8db3140db184 P2: Recreate accessible when select size or multiple changes. r=morgan https://hg.mozilla.org/integration/autoland/rev/2355494e86d0 P3: Fire state change events for select[multiple]. r=morgan
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: