Affected versions

• 94.0a1 (20210929155324)

Affected platforms

• Windows 10 x64

Preconditions

• Dark OS theme

Steps to reproduce

1. Open the latest Nightly profile manager or Create New Profile from about:profiles page.

Expected result

• Profile Manager is displayed as expected.

Actual result

• White background on buttons and white text inside Profile Manager.

Regression range

• Last good revision: edb7b0ca847baac1ebc8c79f056c4ee08d0a480f
  First bad revision: e6687d345d537ca669921fa18cc72e399b6a83b2
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=edb7b0ca847baac1ebc8c79f056c4ee08d0a480f&tochange=e6687d345d537ca669921fa18cc72e399b6a83b2

Notes

• Attached a screenshot.

Morgan, can you please have a look? Thank you!

Same issue in dialog you get when opening a .zip file; field and buttons have bad colors on dark/system theme.

And bad Restart button bg/color on "Help -> About Nightly", too.

[Tracking Requested - why for this release]: We should fix this or back out the regressor (bug 1731678) before 94 goes to beta next week, if possible.

(In reply to Daniel Holbert [:dholbert] from comment #3)

[Tracking Requested - why for this release]: We should fix this or back out the regressor (bug 1731678) before 94 goes to beta next week, if possible.

if we backout the current fix for bug 1731678, I think we should try to land the alternative CSS fix at least

This effectively reverts part of the regressing bug
(bug 1731678) temporarily.

The right fix is described in a comment:

• Make the native Windows theme play well with dark system colors, or
• Stop using the native Windows theme in the UI (like other browsers), or
• Detect properly (rather than via ifdef) whether the native theme is used on
  callers to GenericDarkColor (so that we can eventually expose the colors in
  nsNativeBasicThemeWin-using documents, but not in nsThemeWin-using
  documents).

In any case, that seems at least post-freeze material, and the remaining colors
we expose still allows us to fix bug 1731678.

https://hg.mozilla.org/mozilla-central/rev/86a10437e3e9

This bug seems to be reintroduced in todays (2021-10-05) Nightly build, it was fixed in yesterdays...

Limited to Nightly builds - verified on 95.0a1 (2021-10-06).
94.0b2 does not have the theme implemented yet.

Based on Comment 12, I'm marking this issue as Verified Fixed.