Open Bug 1733498 Opened 3 years ago Updated 2 years ago

Migrate necko errors l10n strings from .properties to Fluent

Categories

(Core :: Networking, task, P2)

task

Tracking

()

ASSIGNED

People

(Reporter: zbraniecki, Assigned: manuel)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

There are only several of those strings: https://searchfox.org/mozilla-central/rev/7539ad54ddc720a0553efd07ca681b9a409f9887/netwerk/locales/en-US/necko.properties#5-15

but they show up quite a bit in arewefluentyet.com - and the keys like 6 and 12 are hard to debug.

We should migrate it to more meaningful keys and use Fluent.

This is some subset of https://searchfox.org/mozilla-central/search?q=symbol:M_969b4ac57a0ae13a&redirect=false - I don't think we need to migrate all of necko.properties at once, just the error keys, so maybe just one or two of those callsites.

What is the priority for this work? Should the necko team do this or the fluent team?

Flags: needinfo?(zbraniecki)

Hi Dragana, I'd mark it as P4 - it's a tech debt reduction (low) but as part of the major platform Key Result ("Unify Localization").

The work should be done by the necko team as part of tech debt reduction cycle.

Flags: needinfo?(zbraniecki)

Thank you.

Jens, can you prioritize this with our other work?

Flags: needinfo?(jstutte)

Hi Manuel, can you take this?

Flags: needinfo?(jstutte) → needinfo?(mbucher)

Yes, I'll look into this.

Assignee: nobody → mbucher
Flags: needinfo?(mbucher)
Severity: -- → S4
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [necko-triaged]

My currently gathered information on this bug:

Depends on: 1752552

From a review of the current arewefluentyet.com M2 data, it looks like the CookieLaxForced2 string from necko.properties is also formatted during startup. Should that get its own bug, or will it get migrated along with the numerical messages here?

Comment on attachment 9260146 [details]
WIP: Bug 1733498 - Migrate necko errors l10n strings from properties to Fluent

Revision D136612 was moved to bug 1771867. Setting attachment 9260146 [details] to obsolete.

Attachment #9260146 - Attachment is obsolete: true

Manuel, is the patch that was at https://phabricator.services.mozilla.com/D136612?id=532851 before it got renamed & reformatted to something completely different something that might still eventually land?

Flags: needinfo?(manuel)
Blocks: 1581212
No longer blocks: 1501881

Oh, thats where the duplicate patch came from ^^. I'll look into restoring and completing the patch.

Flags: needinfo?(manuel)
Attachment #9260146 - Attachment is obsolete: false
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: