Migrate necko errors l10n strings from .properties to Fluent
Categories
(Core :: Networking, task, P2)
Tracking
()
People
(Reporter: zbraniecki, Assigned: manuel)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
There are only several of those strings: https://searchfox.org/mozilla-central/rev/7539ad54ddc720a0553efd07ca681b9a409f9887/netwerk/locales/en-US/necko.properties#5-15
but they show up quite a bit in arewefluentyet.com - and the keys like 6
and 12
are hard to debug.
We should migrate it to more meaningful keys and use Fluent.
This is some subset of https://searchfox.org/mozilla-central/search?q=symbol:M_969b4ac57a0ae13a&redirect=false - I don't think we need to migrate all of necko.properties at once, just the error keys, so maybe just one or two of those callsites.
Comment 1•3 years ago
|
||
What is the priority for this work? Should the necko team do this or the fluent team?
Reporter | ||
Comment 2•3 years ago
|
||
Hi Dragana, I'd mark it as P4 - it's a tech debt reduction (low) but as part of the major platform Key Result ("Unify Localization").
The work should be done by the necko team as part of tech debt reduction cycle.
Comment 3•3 years ago
|
||
Thank you.
Jens, can you prioritize this with our other work?
Comment 4•3 years ago
|
||
Hi Manuel, can you take this?
Assignee | ||
Comment 5•3 years ago
|
||
Yes, I'll look into this.
Updated•3 years ago
|
Assignee | ||
Comment 6•3 years ago
|
||
My currently gathered information on this bug:
-
The status code is directly mapped to the .properties translation using the
FormatStatusMessage
function: /uriloader/base/nsDocLoader.cpp#1230 -> this is where the change to .fluent for this bug report happens (and is still TODO for me)- EDIT(2022-01-11 from asking in matrix room #l10n-dev:mozilla.org): Other examples of using Fluent in C++: https://searchfox.org/mozilla-central/search?q=Localization%3A%3ACreate&path=.cpp&case=true®exp=false
-
FormatStatusMessage
is implemented in /intl/strres/nsStringBundle.cpp#945-995 -
Only other usage of
FormatStatusMessage
I can see: /dom/xslt/xslt/txMozillaXSLTProcessor.cpp#1033, so I guess this function could get deprecated and removed soon -
migration of the strings is is rather painless because of https://github.com/mozilla/properties-to-ftl
Assignee | ||
Comment 7•3 years ago
|
||
Comment 8•3 years ago
|
||
From a review of the current arewefluentyet.com M2 data, it looks like the CookieLaxForced2
string from necko.properties
is also formatted during startup. Should that get its own bug, or will it get migrated along with the numerical messages here?
Comment 9•2 years ago
|
||
Comment on attachment 9260146 [details]
WIP: Bug 1733498 - Migrate necko errors l10n strings from properties to Fluent
Revision D136612 was moved to bug 1771867. Setting attachment 9260146 [details] to obsolete.
Comment 10•2 years ago
|
||
Manuel, is the patch that was at https://phabricator.services.mozilla.com/D136612?id=532851 before it got renamed & reformatted to something completely different something that might still eventually land?
Assignee | ||
Comment 11•2 years ago
|
||
Oh, thats where the duplicate patch came from ^^. I'll look into restoring and completing the patch.
Updated•2 years ago
|
Description
•