Disable window occlusion on some tests
Categories
(Core :: Widget: Win32, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox95 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Window occlusion caused test timeout failures on several test. It seems necessary to disable window occlusion on these tests.
https://treeherder.mozilla.org/jobs?repo=try&revision=16c4bc573147b78f232926b3cd0476986c51770e
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
Depends on D126710
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
From gfx-apac meeting
- It is OK to disable Window Occlusion on web platform test
- We need to run common test suites with window occlusion.
Assignee | ||
Comment 4•3 years ago
|
||
Test results without disabling window occlusion, there are many timeout failures.
https://treeherder.mozilla.org/jobs?repo=try&revision=7a63a269ffe34c6aad407cab4a517b8ed27325e1
Updated•3 years ago
|
Assignee | ||
Comment 5•3 years ago
|
||
With D127446, almost all timeout failure seemed to be addressed.
https://treeherder.mozilla.org/jobs?repo=try&revision=458c7ecb0a8494d06574835ef9427c08854c878f
Assignee | ||
Comment 6•3 years ago
|
||
Looking into why testing window was occluded by other window during test.
There were 3 causes to cause window occlusion
- [1] Multiple Firefox instances existed. A window of one instance occluded other window of another instance.
- This happened frequently during web platform tests.
- [2] One test created multiple windows. One window occluded other window.
- On CI, display size seemed small, it caused testing windows were often maximized.
- Multiple maximized windows caused window occlusion.
- [3] window is not shown(does not have WS_VISIBLE). The window is judged as occluded.
Assignee | ||
Comment 7•3 years ago
|
||
Looked into why tests timeout failures by window occlusion did not happen on macOS.
- On macOS, "occlusionstatechange" event happened less often. It seems to related to the failures difference.
- On macOS, window's sizes were not maximized during tests. On Windows, Majority of windows were maximized.
Maximized windows caused "occlusionstatechange" events on Windows.
It might be related to window size difference. macOS had bigger display size.
- macOS display size: 1920 * 1080
- Windows display size: 1280 * 1024
When non-maximized Firefox windows had same size and position, it caused "occlusionstatechange" event on Window.
But it did not cause "occlusionstatechange" event on macOS.
On macOS, window corners are rounded. I wonder if it might be related to it.
Assignee | ||
Comment 8•3 years ago
|
||
Looked into why testing windows were maximized on Windows.
CI testing PC's display size was (1280 * 1024). With the size, following code was hit. It caused the maximized window.
Updated•3 years ago
|
Assignee | ||
Comment 9•3 years ago
|
||
Test result with patches.
test result without change.
Comment 10•3 years ago
|
||
Comment 12•3 years ago
|
||
bugherder |
Description
•