Closed Bug 1733958 Opened 3 years ago Closed 3 years ago

7.8 - 2.58% fandom ContentfulSpeedIndex / wasm-godot + 2 more (Linux, OSX) regression on Tue September 28 2021

Categories

(Core :: Networking: Cache, defect, P1)

Product:
Core
Component:
Networking: Cache
Version:
Firefox 95
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- unaffected
firefox94 --- fixed
firefox95 --- fixed

People

(Reporter: alexandrui, Assigned: valentin)

References

(Regressed 1 open bug, Regression)

Details

(Keywords: perf, perf-alert, regression, Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1733958 - Set network.cache.bug1708673 to false r=#necko
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details

Perfherder has detected a browsertime performance regression from push ab1b0594e2a8fd602241548d1c0cd631b5820fdb. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
8% fandom ContentfulSpeedIndex linux1804-64-shippable-qr warm webrender 260.83 -> 281.17
6% fandom SpeedIndex linux1804-64-shippable-qr warm webrender 337.42 -> 357.67
6% fandom SpeedIndex linux1804-64-shippable-qr warm webrender 336.62 -> 356.50
3% wasm-godot macosx1015-64-shippable-qr webrender 522.89 -> 536.36

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
4% wikipedia fnbpaint macosx1014-64-shippable-qr warm webrender 961.08 -> 921.54

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(valentin.gosu)

I'll send a patch to pref off on beta and will try to fix again on nighly.

Assignee: nobody → valentin.gosu
Flags: needinfo?(valentin.gosu)
Priority: -- → P1
Whiteboard: [necko-triaged]

Bug 1731054 and bug 1708673 caused a performance regression.
We should disable the pref (on beta) to fix the regression while we investigate the causes.

Set release status flags based on info from the regressing bug 1731054

status-firefox93: --- → unaffected
status-firefox95: --- → affected
status-firefox-esr78: --- → unaffected
status-firefox-esr91: --- → unaffected

https://hg.mozilla.org/mozilla-central/rev/e15c1956a0eb

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(valentin.gosu)

Comment on attachment 9245216 [details]
Bug 1733958 - Set network.cache.bug1708673 to false r=#necko

Beta/Release Uplift Approval Request

  • User impact if declined: Potential performance regression.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Bug was introduced recently
  • String changes made/needed:
Flags: needinfo?(valentin.gosu)
Attachment #9245216 - Flags: approval-mozilla-beta?

Comment on attachment 9245216 [details]
Bug 1733958 - Set network.cache.bug1708673 to false r=#necko

Approved for 94.0b5.

Attachment #9245216 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

(In reply to Pulsebot from comment #4)

Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e15c1956a0eb
Set network.cache.bug1708673 to false r=nhnt11

== Change summary for alert #31834 (as of Wed, 13 Oct 2021 04:59:36 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
4% fandom fnbpaint linux1804-64-shippable-qr fission warm webrender 201.67 -> 193.62

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=31834

Has Regression Range: --- → yes
Regressions: 1778961
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: