Closed Bug 1733978 Opened 3 years ago Closed 3 years ago

gui-challenges.web.app/media-scroller doesn't work appropriately on Nightly

Categories

(Core :: Layout: Grid, defect)

Product:
Core
Component:
Layout: Grid
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox92 --- unaffected
firefox93 --- unaffected
firefox94 --- disabled
firefox95 --- disabled
firefox96 --- fixed

People

(Reporter: emilio, Assigned: sefeng)

References

(Regression,
URL
)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1733978 - Don't overwrite the ISize of child frames when optimizing nested grid layout r=mats
(deleted), text/x-phabricator-request
Details

[Tracking Requested - why for this release]: Layout regression that could affect other sites.

tracking-firefox94: --- → ?

Looking...

And the pref is only enabled in Nightly, do we still need the tracking flag?

Ah, guess not.

Blocks: 1732082
tracking-firefox94: + → ---

Set release status flags based on info from the regressing bug 1591366

status-firefox95: --- → affected

I don't think the status-firefox95 is correct because this feature is currently Nightly only.

status-firefox95: affected → disabled
Flags: needinfo?(sefeng)
Assignee: nobody → sefeng

The severity field is not set for this bug.
:jwatt, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jwatt)

Setting S3 since it's only affected on nightly builds.

Severity: -- → S3
Flags: needinfo?(jwatt)

The optimized code path for nested grid layout should only set the
BSize of the child frames, since this is what the optimization is
for.

Without the change, the ISize is always going to be set to 0 for
child frames which may break the layout. Sometimes, it is not
an issue because the ISize of the grid area gets updated, so
the cached measurement becomes invalid, and the ISize of the child
frame gets set to the correct one again.

Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/93310707d7c5 Don't overwrite the ISize of child frames when optimizing nested grid layout r=mats
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31581 for changes under testing/web-platform/tests

https://hg.mozilla.org/mozilla-central/rev/93310707d7c5

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Upstream PR merged by moz-wptsync-bot
Regressions: 1740702
QA Whiteboard: [qa-96b-p2]
Regressions: 1746228
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: