Some themes have borders around the active tab when they should not
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
All of the themes show a border around the active tab (tab_line
in the theme API), but only the Bold themes should have this. The preview images should be updated as well.
[Tracking Requested - why for this release]:
Incorrect appearance in new themes.
Assignee | ||
Comment 1•3 years ago
|
||
This bug was due to an error in the script, where colord("transparent").toHslString()
was being converted to hsl(0, 0, 0%)
. See the fix here: https://github.com/htwyford/create-theme-script/pull/8/files.
The new section in preview.svg that adds a glow to the active tab is pulled from the light theme: https://searchfox.org/mozilla-central/rev/01adc17c9a41d9f7975de170acc78634bd743609/browser/themes/addons/light/preview.svg#6,8,20-35
Updated•3 years ago
|
Updated•3 years ago
|
Comment 3•3 years ago
|
||
Comment on attachment 9244426 [details]
Bug 1734237 - Remove active tab border from Soft/Balanced themes and update previews. r?jaws
Beta/Release Uplift Approval Request
- User impact if declined: Removes the active tab border from the soft/balanced variants of the new colorways themes.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small visual-only change.
- String changes made/needed:
Comment 4•3 years ago
|
||
bugherder |
Comment 5•3 years ago
|
||
Comment on attachment 9244426 [details]
Bug 1734237 - Remove active tab border from Soft/Balanced themes and update previews. r?jaws
Approved for 94.0b4.
Comment 6•3 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Updated•3 years ago
|
Comment 7•3 years ago
|
||
Verified the fix using Windows 10 x64, macOS 10.15 and Ubuntu 18.04 on Firefox 94.0b4 and Firefox 95.0a1. The issue is not reproducing anymore.
Description
•