m-c build fails if no mozconfig is present
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox-esr78 unaffected, firefox-esr91 unaffected, firefox93 unaffected, firefox94 unaffected, firefox95 fixed)
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox-esr91 | --- | unaffected |
firefox93 | --- | unaffected |
firefox94 | --- | unaffected |
firefox95 | --- | fixed |
People
(Reporter: gw, Assigned: glandium)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file, 3 obsolete files)
(deleted),
text/x-phabricator-request
|
Details |
Running ./mach build
on latest m-c fails if there is no mozconfig
file present:
0:12.97 Traceback (most recent call last):
0:12.97 File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
0:12.97 return _run_code(code, main_globals, None,
0:12.97 File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
0:12.97 exec(code, run_globals)
0:12.97 File "/home/gw/code/work/gecko1/python/mozbuild/mozbuild/action/webidl.py", line 20, in <module>
0:12.97 sys.exit(log_build_task(main, sys.argv[1:]))
0:12.97 File "/home/gw/code/work/gecko1/python/mozbuild/mozbuild/action/util.py", line 18, in log_build_task
0:12.97 return f(*args, **kwargs)
0:12.97 File "/home/gw/code/work/gecko1/python/mozbuild/mozbuild/action/webidl.py", line 15, in main
0:12.97 manager = BuildSystemWebIDL.from_environment().manager
0:12.97 File "/home/gw/code/work/gecko1/dom/bindings/mozwebidlcodegen/__init__.py", line 695, in manager
0:12.97 "--enable-dom-streams" in self.mozconfig["configure_args"]
0:12.97 TypeError: argument of type 'NoneType' is not iterable
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
"--enable-dom-streams" in self.mozconfig["configure_args"]
Yeah, that's really not how this should be checked for. And there's a similar construct in layout/tools/reftest/mach_commands.py coming from bug 1642661 and build/mach_initialize.py inherited from bug 1291335.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Assignee | ||
Comment 4•3 years ago
|
||
Assignee | ||
Comment 5•3 years ago
|
||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 9•3 years ago
|
||
bugherder |
Comment 10•3 years ago
|
||
Backed out 2 changesets (Bug 1734523) for causing python failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/b589691183767d6198bf42dcc7522b240db71c2c
Push with failures, failure log.
Update: also caused puppeteer failures.
Assignee | ||
Comment 11•3 years ago
|
||
The issue this was filed for was fixed by what ended up being merged in central. I'll move the remaining to bug 1734754.
Comment 12•3 years ago
|
||
Comment on attachment 9244696 [details]
Bug 1734523 - Remove the use of MozbuildObject.mozconfig in run_jstestbrowser.
Revision D127766 was moved to bug 1734754. Setting attachment 9244696 [details] to obsolete.
Comment 13•3 years ago
|
||
Comment on attachment 9244697 [details]
Bug 1734523 - Remove the use of MozbuildObject.mozconfig in mach_initialize.
Revision D127767 was moved to bug 1734754. Setting attachment 9244697 [details] to obsolete.
Comment 14•3 years ago
|
||
Set release status flags based on info from the regressing bug 1730589
Description
•