Closed Bug 1734582 Opened 3 years ago Closed 3 years ago

Make TextLeafPoint handle display: contents

Categories

(Core :: Disability Access APIs, task)

Product:
Core
Component:
Disability Access APIs
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: Jamie, Assigned: Jamie)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1734582: Don't assert for a null frame in TextLeafPoint::FindPrev/NextLineStartSameLocalAcc.
(deleted), text/x-phabricator-request
Details

TextLeafPoint's line boundary code for LocalAccessibles depends on having a frame. Using display: contents means there'll be no frame. The code needs to be tweaked to handle that case. Right now, it throws an assertion.

I need to look at the existing behaviour here in the old HyperTextAccessible implementation, as well as what makes sense.

This can happen for display: contents.
In that case, there are no lines in the Accessible anyway, so returning an invalid TextLeafPoint (as we already did) is the correct thing to do.

Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/570e6e45882f Don't assert for a null frame in TextLeafPoint::FindPrev/NextLineStartSameLocalAcc. r=morgan

https://hg.mozilla.org/mozilla-central/rev/570e6e45882f

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: