Open Bug 1735229 Opened 3 years ago Updated 1 years ago

about:logins screen stays empty during a long time

Categories

(Firefox :: about:logins, defect, P3)

Firefox 93
defect

Tracking

()

UNCONFIRMED

People

(Reporter: contact, Unassigned)

References

Details

(Keywords: perf)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

I browsed to about:logins

Actual results:

I got an empty Firefox Lockwise screen, with an empty list of logins. My logins show up after around two minutes staying of the page.

Expected results:

My logins should have been displayed from the beginning.

The Bugbug bot thinks this bug should belong to the 'Firefox::about:logins' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → about:logins

Quentin, thanks for filing this. Here are a few questions that should help us out:

  • How many logins do you have? If you happen to have a few hundred logins (~500 or so if I recall correctly), there will be a performance hit and this is a known issue
  • Approximately how old is your profile? It seems like the upgrade from 92 to 93 can cause this issue, but I'm not sure if you have to have primary password enabled for this issue to occur.
  • Do you have primary password enabled? We've been seeing some performance issues when primary password is enabled. This might actually be a dupe of Bug 1729930 where a workaround is to change your primary password (you can change the primary password to be the same one as you used before). After changing your primary password, the issue should resolve itself...if it's the same as the previously mentioned bug.

If you are able to reproduce this consistently, having a profile of what is happening would be beneficial to us. You can find the Firefox profiler here and go ahead and enable the profiler menu button. We'll use the default settings in this case so don't worry about needing to configure it. Activate the menu button (it should be the speedometer looking icon near your Firefox account icon/top right of your monitor) before you visit about:logins and stop it once the page is responsive again. If the profile happens to be too large or doesn't display correctly, don't worry about linking to it.
If you are able to get a profile, after recording it, you need to "upload local profile" which should be near the top right of the profiler window that appears. Go ahead and paste that link into your comment.

Flags: needinfo?(contact)

Hi Tim, thank you for your quick response.

  • I have exactly 302 logins at this time.
  • My profile is definitely older than my upgrade from Firefox 92 to 93, I'd say it's been a year since my last refresh.
  • Primary password is enabled.

I made a profile here: https://share.firefox.dev/3mRxa5z

Flags: needinfo?(contact)

(In reply to Quentin Pugeat from comment #3)

  • I have exactly 302 logins at this time.

Depending on your machine specs, yeah having this many can cause issues on load. I think we have a bug on file for this, but if not I'll go ahead and file and link these up. Note to self, this is the reflow issue where we add the login items one at a time which forces the DOM to recalculate every time each of these items is added.

  • My profile is definitely older than my upgrade from Firefox 92 to 93, I'd say it's been a year since my last refresh.
  • Primary password is enabled.

Thanks for that, definitely aligns with the same conditions as Bug 1729930

I made a profile here: https://share.firefox.dev/3mRxa5z

Perfect, thanks for that. Looking at the profile it seems very similar to the profile in Comment 16 over on Bug 1729930. I don't know if it's worth creating a copy of your key4.db so that this can be consistently reproduced as that file is something that shouldn't be shared. It looks like we have other reporters that are working on the previously mentioned bug.

You could go ahead and change your primary password and see if that fixes some of your performance issues. Instead of 30s, I'd expect maybe 10s or so. Obviously not great, but more manageable.

(In reply to Tim Giles [:tgiles] from comment #4)

You could go ahead and change your primary password and see if that fixes some of your performance issues. Instead of 30s, I'd expect maybe 10s or so. Obviously not great, but more manageable.

I just did and now the screen loads in two or three seconds!

Quentin, could you create another profile now that the large problem is fixed? Just want to make sure we have some actionable items to improve performance here. We shouldn't be taking even that long to load up about:logins (and if we do, we should have some kind of indicator that about:logins is loading).

Thanks for the quick responses, makes my job much easier!

Adding see also due to the fact that this is most likely a dupe.

Flags: needinfo?(contact)
Keywords: perf

(In reply to Tim Giles [:tgiles] from comment #6)

Quentin, could you create another profile now that the large problem is fixed? Just want to make sure we have some actionable items to improve performance here. We shouldn't be taking even that long to load up about:logins (and if we do, we should have some kind of indicator that about:logins is loading).

The about:logins screen loads immediately on a brand new profile with no logins in it.
After I put my 302 logins back into it, the list took one or two seconds to show up again.

Flags: needinfo?(contact)

(In reply to Tim Giles [:tgiles] from comment #6)

Quentin, could you create another profile now that the large problem is fixed?

If you create another profile, could you please change the profiler preset from "Web Developer" to "Firefox Platform" before starting the recording?

(In reply to Florian Quèze [:florian] from comment #8)

If you create another profile, could you please change the profiler preset from "Web Developer" to "Firefox Platform" before starting the recording?

Sorry, I misunderstood Tim's last message.
Here you go: https://share.firefox.dev/3v5y9Te

Severity: -- → S3
Priority: -- → P2
Depends on: 1729930

Hi Tim!
Did you have the opportunity to see the link that the reporter sent you on comment 9?
It is a bit difficult for us to reproduce it with the same reporter conditions. If there is anything we can do, please let us know.

Flags: needinfo?(tgiles)

Hey Marcela, thanks for reaching out. Confirming that I did see the new profile in comment 9. I'll reach out if we need additional QA support but right now I don't think that is needed.

General note, this is most likely a dupe of Bug 1729930 since it was resolved by resetting the primary password. The profile in comment 9 does show some jank though, we should probably figure out how to minimize that jank if possible.

Flags: needinfo?(tgiles)

The about:logins screen loads immediately on a brand new profile with no logins in it.
After I put my 302 logins back into it, the list took one or two seconds to show up again.

Flags: needinfo?(new.madu303)

Lowering priority as it's not happening in the near future.

Priority: P2 → P3

This problem seems to be rooted in a performance bug in the 'Firefox::about:logins' component. This issue arises when a user has a significant number of saved logins (in this case, 302), which causes a significant delay in loading the login screen.

The fact that the login screen loads immediately on a new profile without logins suggests that the delay is related to the amount of data that needs to be loaded and processed.

An important point is that the problem seems to be linked to the use of a primary password on the <a href="https://humidificadorbarato.com/">website</a>. Changing the primary password appears to have significantly improved performance, suggesting that the issue may be related to the way Firefox processes and stores passwords when using a primary password.

It's also possible that the issue is related to the way Firefox handles adding login elements to the DOM, causing it to recalculate each time an element is added. This is particularly problematic when there are a large number of login items to add.

In general, it seems that there are several possible causes of this issue that may need to be addressed to improve the performance of the login screen in Firefox. Although changing the primary password has provided a temporary solution, more significant improvements to the way Firefox handles logins are likely needed to prevent performance issues in the future.

This problem seems to be rooted in a performance bug in the 'Firefox::about:logins' component. This issue arises when a user has a significant number of saved logins (in this case, 302), which causes a significant delay in loading the login screen.

The fact that the login screen loads immediately on a new profile without logins suggests that the delay is related to the amount of data that needs to be loaded and processed.

An important point is that the problem seems to be linked to the use of a primary password on the. Changing the primary password appears to have significantly improved performance, suggesting that the issue may be related to the way Firefox processes and stores passwords when using a primary password.

It's also possible that the issue is related to the way Firefox handles adding login elements to the DOM, causing it to recalculate each time an element is added. This is particularly problematic when there are a large number of login items to add.

In general, it seems that there are several possible causes of this issue that may need to be addressed to improve the performance of the login screen in Firefox. Although changing the primary password has provided a temporary solution, more significant improvements to the way Firefox handles logins are likely needed to prevent performance issues in the future.

For: https://humidificadorbarato.com/

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: