Introduce a context object alongside Watcher Actor universe
Categories
(DevTools :: Framework, task)
Tracking
(firefox96 fixed)
Tracking | Status | |
---|---|---|
firefox96 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-perf-stability-mvp)
Attachments
(3 files)
In order to introduce a third type of context for the WatcherActor, it would be benefitial to introduce a object passed around everywhere around the WatcherActor that would help described what we should debug/expose.
A "context" object store on the Watcher Actor, with a type
attribute that could be:
- "all" for the browser toolbox, which should debug everything
- "browser-element" for tab debugging, which should debug only one given browser-element
And in a near future: - "web-extension" for add-on debugging, and somehow debugging the right browser-element's related to the add-on.
- "service-worker" for debugging workers from about:debugging
Alongside thistype
attribute, we may have as many useful attribute specific to each context type.
type: "all"
would most likely not require anything else,
buttype: "browser-element"
would benefit from abrowserId
attribute to identify the one <browser> element we want to target.
Also, this context object will be transfered to content processes and worker threads, so we should keep in mind to keep it serializable.
Assignee | ||
Comment 1•3 years ago
|
||
This is only the beginning, focusing first on parent process usages.
WatcherActor still expose browserElement shortcut as it is useful in many places.
Context is kept JSON-serializable in order to later pass it through the SessionData.
Assignee | ||
Comment 2•3 years ago
|
||
This is the second and last step, to propagate the context down to the content process.
So that now, whenever we introduce a new context or add something into it,
it should be automatically made available to the whole codebase.
Assignee | ||
Comment 3•3 years ago
|
||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 5•3 years ago
|
||
Backed out 3 changesets (Bug 1735825) for causing bc failures on browser_ext_devtools_inspectedWindow.js.
Backout link
Push with failures
Failure Log
Comment 7•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2e494aaf92a8
https://hg.mozilla.org/mozilla-central/rev/e155545942a8
https://hg.mozilla.org/mozilla-central/rev/87a72f8dd901
Assignee | ||
Updated•3 years ago
|
Description
•