Closed
Bug 1736022
Opened 3 years ago
Closed 3 years ago
[ESLint] Add handleRequest as a used variable for sjs files
Categories
(Developer Infrastructure :: Lint and Formatting, task, P2)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox95 fixed)
RESOLVED
FIXED
95 Branch
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
In bug 1576768 we are turning on ESLint for .sjs files. handleRequest is expected to be defined in sjs files as that is the main function.
We should automatically mark this as used, so that ESLint doesn't complain about it not being used.
|
Assignee | |
Comment 1•3 years ago
|
||
This moves the more expensive check for testing the file type until after we've found an instance of setTimeout.
This is quicker as the initial checks are for simple comparisons.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D128594
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/688c4dce6f82
Speed up ESLint rule no-arbitrary-setTimeout.js. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/448e4e17ceff
For ESLint, mark 'handleRequest' as a used variable for sjs files. r=Gijs
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/688c4dce6f82
https://hg.mozilla.org/mozilla-central/rev/448e4e17ceff
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•