Closed Bug 1736459 Opened 3 years ago Closed 3 years ago

Update builders to rustc 1.56

Tracking

(firefox95 fixed)

Status:

RESOLVED FIXED

Milestone:

95 Branch

Tracking Flags:

Tracking

Status

firefox95

---

fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Bug 1736459 - Update builders to rustc 1.56. 3 years ago Mike Hommey [:glandium] (deleted), text/x-phabricator-request		Details
Bug 1736459 - Switch the spidermonkey fuzzing build to clang 13. 3 years ago Mike Hommey [:glandium] (deleted), text/x-phabricator-request		Details
Bug 1736459 - Disable rust lto when enabling sancov. 3 years ago Mike Hommey [:glandium] (deleted), text/x-phabricator-request		Details
Bug 1736459 - Disable test_crash_backgroundtask_moz_crash.js on Windows. 3 years ago Mike Hommey [:glandium] (deleted), text/x-phabricator-request		Details
Bug 1736459 - Handle null RawHandles in winapi-util. 3 years ago Mike Hommey [:glandium] (deleted), text/x-phabricator-request		Details
Bug 1736459 - Restore the HandleRef::as_file and as_file_mut methods for geckodriver. 3 years ago Mike Hommey [:glandium] (deleted), text/x-phabricator-request		Details

Mike Hommey [:glandium]

Assignee

Description

•

3 years ago

When it releases (should be oct 21)

Mike Hommey [:glandium]

Assignee

Comment 1

•

3 years ago

Attached file Bug 1736459 - Update builders to rustc 1.56. (deleted) — Details

Arthur K. (he/him)

Comment 2

•

3 years ago

Was released today.

Pulsebot

Comment 3

•

3 years ago

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/47fdc6711870 Update builders to rustc 1.56. r=firefox-build-system-reviewers,andi

Marian-Vasile Laza

Comment 4

•

3 years ago

Backed out changeset 47fdc6711870 (Bug 1736459) for causing build bustages.
Backout link
Push with failures - f
Failure Log

Flags: needinfo?(mh+mozilla)

Mike Hommey [:glandium]

Assignee

Updated

•

3 years ago

Depends on: 1737196

Mike Hommey [:glandium]

Assignee

Updated

•

3 years ago

Depends on: 1737197

Mike Hommey [:glandium]

Assignee

Updated

•

3 years ago

Depends on: 1731708, 1731707, 1730397, 1735905

Flags: needinfo?(mh+mozilla)

Pulsebot

Comment 5

•

3 years ago

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/cb0bd4552c26 Update builders to rustc 1.56. r=firefox-build-system-reviewers,andi

Mike Hommey [:glandium]

Assignee

Comment 6

•

3 years ago

Attached file Bug 1736459 - Switch the spidermonkey fuzzing build to clang 13. (deleted) — Details

It was waiting for rust 1.56. Consequently remove clang 12, since it's
not used anymore.

Pulsebot

Comment 7

•

3 years ago

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/1548d79706bb Switch the spidermonkey fuzzing build to clang 13.

Noemi Erli[:noemi_erli]

Comment 8

•

3 years ago

Backed out 2 changesets (Bug 1736459) for causing SM bustage CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1548d79706bb9405e5279c9ce3ec2fdd322a49e0&selectedTaskRun=ZB_9TXofQWuizZ_yo7KJWw.0

Log: https://treeherder.mozilla.org/logviewer?job_id=355793800&repo=autoland&lineNumber=6162
Also: https://treeherder.mozilla.org/logviewer?job_id=355793058&repo=autoland&lineNumber=2375
xpc failures: https://treeherder.mozilla.org/logviewer?job_id=355796157&repo=autoland&lineNumber=1971

Backout: https://hg.mozilla.org/integration/autoland/rev/2f38fe6c1e984327c52bacf14ab4467a9571139f

Flags: needinfo?(mh+mozilla)

Mike Hommey [:glandium]

Assignee

Comment 9

•

3 years ago

(In reply to Noemi Erli[:noemi_erli] from comment #8)

Log: https://treeherder.mozilla.org/logviewer?job_id=355793800&repo=autoland&lineNumber=6162

Filed https://github.com/rust-lang/rust/issues/90300. As a workaround, we can disable LTO on those fuzzing builds.

Flags: needinfo?(mh+mozilla)

Mike Hommey [:glandium]

Assignee

Comment 10

•

3 years ago

(In reply to Noemi Erli[:noemi_erli] from comment #8)

xpc failures: https://treeherder.mozilla.org/logviewer?job_id=355796157&repo=autoland&lineNumber=1971

This one turned green before the backout: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=H1jD5VjXTW-7jd2pnw93GA.0&searchStr=Windows%2C10%2Cx64%2C2004%2CWebRender%2Copt%2CXpcshell%2Ctests%2Ctest-windows10-64-2004-qr%2Fopt-xpcshell-e10s%2CX1&tochange=2f38fe6c1e984327c52bacf14ab4467a9571139f&fromchange=afcf62ffe91d6118c271380e19492c7e43481cdd

Mike Hommey [:glandium]

Assignee

Comment 11

•

3 years ago

Attached file Bug 1736459 - Disable rust lto when enabling sancov. (deleted) — Details

Mike Hommey [:glandium]

Assignee

Comment 12

•

3 years ago

(In reply to Mike Hommey [:glandium] from comment #10)

(In reply to Noemi Erli[:noemi_erli] from comment #8)

xpc failures: https://treeherder.mozilla.org/logviewer?job_id=355796157&repo=autoland&lineNumber=1971

This one turned green before the backout: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=H1jD5VjXTW-7jd2pnw93GA.0&searchStr=Windows%2C10%2Cx64%2C2004%2CWebRender%2Copt%2CXpcshell%2Ctests%2Ctest-windows10-64-2004-qr%2Fopt-xpcshell-e10s%2CX1&tochange=2f38fe6c1e984327c52bacf14ab4467a9571139f&fromchange=afcf62ffe91d6118c271380e19492c7e43481cdd

Weirdly enough, this is reproducible with a try of current central+the patches from this bug.

Mike Hommey [:glandium]

Assignee

Comment 13

•

3 years ago

Attached file Bug 1736459 - Disable test_crash_backgroundtask_moz_crash.js on Windows. (deleted) — Details

Olivier Tilloy

Comment 14

•

3 years ago

The firefox snap is built on Ubuntu 20.04, and uses rustup to get the latest rustc stable release. When 1.56.0 was released, builds started to exhibit a regression in audio capture in WebRTC applications. Pinning the rust version to 1.55.0 fixes the problem.

I haven't had a chance to dig deeper yet, but I thought I'd mention it here, in case it's not just the snap that's affected.

Mike Hommey [:glandium]

Assignee

Comment 15

•

3 years ago

Attached file Bug 1736459 - Handle null RawHandles in winapi-util. (deleted) — Details

This works around a regression in rust 1.56's libstd.

Pulsebot

Comment 16

•

3 years ago

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/59eeaeafdf67 Don't initialize env_logger when stdout/stderr don't exist on Windows. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/2a8f412c4d08 Disable rust lto when enabling sancov. r=truber https://hg.mozilla.org/integration/autoland/rev/798893f69a02 Disable test_crash_backgroundtask_moz_crash.js on Windows. r=gsvelto https://hg.mozilla.org/integration/autoland/rev/0b2da7db414c Update builders to rustc 1.56. r=firefox-build-system-reviewers,andi https://hg.mozilla.org/integration/autoland/rev/c934eeb21692 Switch the spidermonkey fuzzing build to clang 13. r=firefox-build-system-reviewers,andi

Norisz Fay [:noriszfay]

Comment 17

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/59eeaeafdf67
https://hg.mozilla.org/mozilla-central/rev/2a8f412c4d08
https://hg.mozilla.org/mozilla-central/rev/798893f69a02
https://hg.mozilla.org/mozilla-central/rev/0b2da7db414c
https://hg.mozilla.org/mozilla-central/rev/c934eeb21692

Status: NEW → RESOLVED

Closed: 3 years ago

status-firefox95: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 95 Branch

Norisz Fay [:noriszfay]

Comment 18

•

3 years ago

Backed out for causing Windows crashes (Bug 1738034)

Backout link: https://hg.mozilla.org/mozilla-central/rev/71089265de178cef408d0b861f6252fe6d9ace35

Status: RESOLVED → REOPENED

status-firefox95: fixed → ---

Flags: needinfo?(mh+mozilla)

Resolution: FIXED → ---

Target Milestone: 95 Branch → ---

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Updated

•

3 years ago

Regressions: 1738034

Phabricator Automation

Updated

•

3 years ago

Attachment #9247874 - Attachment description: Bug 1736459 - Don't initialize env_logger when stdout/stderr don't exist on Windows. → Bug 1736459 - Use a dummy logger when stdout/stderr don't exist on Windows.

Phabricator Automation

Updated

•

3 years ago

Attachment #9247874 - Attachment description: Bug 1736459 - Use a dummy logger when stdout/stderr don't exist on Windows. → Bug 1736459 - Handle null RawHandles in winapi-util.

Pulsebot

Comment 19

•

3 years ago

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/78d10730d088 Handle null RawHandles in winapi-util. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/48e08e929ce7 Disable rust lto when enabling sancov. r=truber https://hg.mozilla.org/integration/autoland/rev/3c96bab38c95 Disable test_crash_backgroundtask_moz_crash.js on Windows. r=gsvelto https://hg.mozilla.org/integration/autoland/rev/de36c45ed2a7 Update builders to rustc 1.56. r=firefox-build-system-reviewers,andi https://hg.mozilla.org/integration/autoland/rev/3d8df6da990d Switch the spidermonkey fuzzing build to clang 13. r=firefox-build-system-reviewers,andi

Mike Hommey [:glandium]

Assignee

Comment 20

•

3 years ago

Attached file Bug 1736459 - Restore the HandleRef::as_file and as_file_mut methods for geckodriver. (deleted) — Details

Pulsebot

Comment 21

•

3 years ago

Pushed by malexandru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ad8ebf7de356 Restore the HandleRef::as_file and as_file_mut methods for geckodriver. r=nika

Mike Hommey [:glandium]

Assignee

Updated

•

3 years ago

Flags: needinfo?(mh+mozilla)

Noemi Erli[:noemi_erli]

Comment 22

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/78d10730d088
https://hg.mozilla.org/mozilla-central/rev/48e08e929ce7
https://hg.mozilla.org/mozilla-central/rev/3c96bab38c95
https://hg.mozilla.org/mozilla-central/rev/de36c45ed2a7
https://hg.mozilla.org/mozilla-central/rev/3d8df6da990d
https://hg.mozilla.org/mozilla-central/rev/ad8ebf7de356

Status: REOPENED → RESOLVED

Closed: 3 years ago → 3 years ago

status-firefox95: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 95 Branch

Mike Hommey [:glandium]

Assignee

Updated

•

3 years ago

Regressions: 1736970

Arthur K. (he/him)

Comment 23

•

3 years ago

Does Rust 1.56 for FF95 need to bumped to 1.56.1 to address https://blog.rust-lang.org/2021/11/01/cve-2021-42574.html ?

Sylvestre Ledru [:Sylvestre]

Comment 24

•

3 years ago

Probably not, we have now a linter for this which will break the ci if it happens

Nick Alexander :nalexander [he/him] (PTO until Montreallhands August 21, 2023)

Updated

•

2 years ago

Blocks: 1794054

You need to log in before you can comment on or make changes to this bug.