Closed
Bug 1736486
Opened 3 years ago
Closed 3 years ago
[rust 1.57] ld.lld: error: undefined symbol: BCryptGenRandom
Categories
(Firefox Build System :: General, defect, P3)
Firefox Build System
General
Tracking
(firefox-esr91 fixed, firefox96 fixed)
RESOLVED
FIXED
96 Branch
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr91+
|
Details |
[task 2021-10-19T00:40:32.387Z] 00:40:32 INFO - ld.lld: error: undefined symbol: BCryptGenRandom
[task 2021-10-19T00:40:32.388Z] 00:40:32 INFO - >>> referenced by /rustc/4e89811b46323f432544f9c4006e40d5e5d7663f\/library\std\src\sys\windows\rand.rs:10
[task 2021-10-19T00:40:32.389Z] 00:40:32 INFO - >>> libmozwer_s.a(mozwer_s-b4383626653fb7f4.mozwer_s.7a61e29c-cgu.0.rcgu.o):(std::collections::hash::map::RandomState::new::KEYS::__getit::h53be9d6cad892b99)
[task 2021-10-19T00:40:32.389Z] 00:40:32 INFO - clang-13: error: linker command failed with exit code 1 (use -v to see invocation)
Assignee | ||
Comment 1•3 years ago
|
||
This is a very recent regression in rustc, I'm going to see if it can be fixed there.
Assignee | ||
Comment 2•3 years ago
|
||
It comes from https://github.com/rust-lang/rust/pull/84096, and mozwer is just the first thing this happens with.
Component: Crash Reporting → General
Product: Toolkit → Firefox Build System
Updated•3 years ago
|
Priority: -- → P3
Assignee | ||
Updated•3 years ago
|
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Updated•3 years ago
|
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 4•3 years ago
|
||
rust 1.57's libstd adds a dependency on bcrypt on Windows.
Updated•3 years ago
|
Assignee: nobody → mh+mozilla
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/5b205316ef5c
Link bcrypt where needed. r=firefox-build-system-reviewers,andi
Comment 6•3 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Assignee | ||
Comment 7•3 years ago
|
||
Comment on attachment 9252423 [details]
Bug 1736486 - Link bcrypt where needed.
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build failure on Windows with rustc 1.57
- User impact if declined: Downstreams that may be building with a recent rust compiler get a build failure.
- Fix Landed on Version: 96
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Practically speaking, it's NPOTB for us.
Attachment #9252423 -
Flags: approval-mozilla-esr91?
Comment 8•3 years ago
|
||
Comment on attachment 9252423 [details]
Bug 1736486 - Link bcrypt where needed.
Approved for 91.5esr.
Attachment #9252423 -
Flags: approval-mozilla-esr91? → approval-mozilla-esr91+
Comment 9•3 years ago
|
||
bugherder uplift |
status-firefox-esr91:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•