Closed Bug 1736508 Opened 3 years ago Closed 3 years ago

Make TCPSocket work with ipv6 address again

Categories

(Core :: DOM: Networking, defect, P2)

Product:
Core
Component:
DOM: Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- fixed
firefox93 --- wontfix
firefox94 --- wontfix
firefox95 --- fixed

People

(Reporter: rnons, Assigned: rnons)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1736508 - Make TCPSocket work with ipv6 address again. r=valentin
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-esr91+
Details

When constructing nsIURI, need to wrap ipv6 address in [ ]

Assignee: nobody → remotenonsense
Blocks: 1728773
Status: NEW → ASSIGNED

Wrap ipv6 address in [ ] when constructing nsIURI.

Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged]
Pushed by remotenonsense@gmail.com: https://hg.mozilla.org/integration/autoland/rev/41d43f5c48c2 Make TCPSocket work with ipv6 address again. r=valentin

Set release status flags based on info from the regressing bug 902346

status-firefox93: --- → affected
status-firefox94: --- → affected
status-firefox95: --- → affected
status-firefox-esr78: --- → unaffected
status-firefox-esr91: --- → affected

Backed out changeset 41d43f5c48c2 (Bug 1736508) for causing mochitest failures on test_tcpsocket_jsm.html.
Backout link
Push with failures - c2
Failure Log

Flags: needinfo?(remotenonsense)
Pushed by remotenonsense@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7353fe4d388b Make TCPSocket work with ipv6 address again. r=valentin
Flags: needinfo?(remotenonsense)

https://hg.mozilla.org/mozilla-central/rev/7353fe4d388b

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox95: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

Comment on attachment 9246581 [details]
Bug 1736508 - Make TCPSocket work with ipv6 address again. r=valentin

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed by thunderbird.
  • User impact if declined: No impact to firefox users. Thunderbird users can't connect to SMTP server with ipv6 address as host name.
  • Fix Landed on Version: 95
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not risky because the feature is not used by firefox.
  • String or UUID changes made by this patch:
Attachment #9246581 - Flags: approval-mozilla-esr91?

Comment on attachment 9246581 [details]
Bug 1736508 - Make TCPSocket work with ipv6 address again. r=valentin

Approved for 91.4esr.

Attachment #9246581 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: