[Linux] Polish titlebar config
Categories
(Core :: Widget: Gtk, task)
Tracking
()
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 2 obsolete files)
Right now we don't test titlebar rendering in mozilla testsuite. That leads to various issues and regressions.
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Recently -moz-gtk-csd-hide-titlebar-by-default is used to control initial state of titlebar rendering on Linux.
This is used on Linux only, such preference confuses Mozilla test suite which expects browser.tabs.drawInTitlebar only
as it's used on other platforms.
Let's align Linux behaviors with Win/Mac and set browser.tabs.drawInTitlebar directly at browser start (if it's not already set).
Depends on D128995
|
||
Comment 3•3 years ago
|
||
To more properly support Linux having a different default at runtime.
Expose the resolved value in appinfo for convenience, and use it in the
front-end as needed.
|
|
||
Comment 4•3 years ago
|
||
This is a regression from bug 1681356. nsWindow::GtkWindowDecoration()
default-initializes a GtkWindowDecoration, which ends up being
GTK_DECORATION_SYSTEM since that's the first variant.
Fix the check by using the proper function
GetSystemGtkWindowDecoration(). Quite a footgun...
Depends on D129004
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62d204b08dce Make browser.tabs.drawInTitlebar a tri-state. r=stransky,Gijs https://hg.mozilla.org/integration/autoland/rev/ad3d2766d9da Fix CSD check in nsLookAndFeel. r=stransky https://hg.mozilla.org/integration/autoland/rev/537090f8fa57 Remove GTK_CSD_DECORATION_UNKNOWN. r=stransky
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/62d204b08dce
https://hg.mozilla.org/mozilla-central/rev/ad3d2766d9da
https://hg.mozilla.org/mozilla-central/rev/537090f8fa57
|
||
Comment 8•3 years ago
|
||
Should this bug still be open? Maybe it would better to create a new followup bug if there is going to be more later.
|
|
||
Comment 9•3 years ago
|
||
Yeah maybe we should retitle this bug and close it? WDYT Martin?
|
|
Assignee | |
Comment 10•3 years ago
|
||
There's try with enabled CSD in try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=018a3bcf76022f97eb1481d95c4d83aebed002e8
so let's see how it works.
|
|
Assignee | |
Comment 11•3 years ago
|
||
Hm, the try does not look good. Okay, let's close it and file another one for CSD enabled in testsuite.
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Description
•