STR

1. Enable HCM
2. Open the "edit bookmark" panel from the address bar
3. Tab to the "save" button

Expected
Focus indicator should be visible

Actual
Focus indicator is difficult to see since its color is similar to the background

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Updated the patch to fix the default appearance of the primary button while in HCM.
Tested on MacOS 15.1 with OS-powered HCM (System Preferences > Accessibility > Display > Increase contrast)

(In reply to Micah [:mtigley] (she/her) from comment #0)

STR

1. Enable HCM
2. Open the "edit bookmark" panel from the address bar
3. Tab to the "save" button

Expected
Focus indicator should be visible

Actual
Focus indicator is difficult to see since its color is similar to the background

I think this was supposed to get fixed in bug 1709587 by having a gap between the background and the focus ring? Or maybe I'm misunderstanding this bug. Could you please post a screenshot of the broken behavior? (Is the screenshot in comment 5 supposed to show something broken? If so I don't see it.)

(In reply to Dão Gottwald [::dao] from comment #6)

I think this was supposed to get fixed in bug 1709587 by having a gap between the background and the focus ring? Or maybe I'm misunderstanding this bug. Could you please post a screenshot of the broken behavior? (Is the screenshot in comment 5 supposed to show something broken? If so I don't see it.)

I believe comment 5 is a screenshot of the issue being fixed by the current patch. I've also attached a screenshot of what I'm seeing on Nightly 98.0a1. Let me know if you need more information!

Thank you for the reply, @Micah!

Just in case, attached is the video of existent behavior from Nightly 98.0a1 for two following controls on the Edit Bookmark panel:

• "Show editor when saving" checkbox
• "Save" button

I'll follow up with the video of their patched by D137819 behavior.

Video of expected / patched behavior of the checkbox and "Save" button is attached.

Micah's screenshot of Nightly from comment comment 7 looks similar to Anna's video of the patched panel from comment 9, so I'm still confused. FWIW, the video from comment 8 looks closer to what I'd expect in high contrast mode on macOS, and what's shown in comment 7 and comment 9 does look broken to me.

(In reply to Dão Gottwald [::dao] from comment #10)

Micah's screenshot of Nightly from comment comment 7 looks similar to Anna's video of the patched panel from comment 9, so I'm still confused. FWIW, the video from comment 8 looks closer to what I'd expect in high contrast mode on macOS, and what's shown in comment 7 and comment 9 does look broken to me.

Dao, I am very sorry for the confusion - the videos are mismatched... The one with blue "Save" and checkbox is actual and the black and white appearance is an expected behavior. At the beginning of the video that is (mistakenly) called "current", the Restore Session buttons are good example of proper HCM behavior.

(In reply to Anna Yeddi [:ayeddi] from comment #11)

The one with blue "Save" and checkbox is actual and the black and white appearance is an expected behavior. At the beginning of the video that is (mistakenly) called "current", the Restore Session buttons are good example of proper HCM behavior.

Thanks for clarifying, Anna! And to verify this, I applied Anna's latest patch and can confirm that the attachment in comment 8 is what I'm seeing. And without it applied, I'm seeing what's attached in comment 9.

I did some refactoring in bug 1755023 that I think should make a difference here. Would you please re-test and see what's left to do here?

Thanks Dao! Apologies for the late reply.

So it seems like the HCM styles for high contrast mode are removed, but I'm noticing it with other buttons in the hamburger menu as well. Are we planning to add these styles back?

Edit: these are my settings while testing this on MacOS

1. I made sure that Display --> Increase contrast is enabled.
2. System theme -- auto is enabled for my browser theme

It looks like -moz-mac-focusring isn't updated / doesn't provide enough contrast in HCM. Does -moz-accent-color work? In that case we'd just need to restrict https://searchfox.org/mozilla-central/rev/3de1b6791ea569cdf7773f7cd512cf2e6cc1d3f0/toolkit/themes/osx/global/global.css#11 to @media not (prefers-contrast).

Thank you Dao for the patch and Micah for testing too!

It looks like the patch for the bug 1755023 did partially fix this bug on MacOS and updated focused state presentation on WinOS, while probably fixing a set of other bugs related to the focus indication for active chrome UI:

• The focus outlines are now consistently styled across the UI

But there is one regression that was observed - the color of the outline. For the MacOS, the bug 1755813 was filed, because the accent color used with transparency that would not provide sufficient contrast for the outline on either Light or Dark themes. But opaque color would resolve this issue and provide full fix and expected, accessible behavior across the UI.

Let me know if you have any questions.

Thank you, Dão Gottwald [::dao] , for updating (D139045)[https://phabricator.services.mozilla.com/D139045] patch.

The focus outline works within the chrome UI as expected on MacOS 12.2 with Increased Contrast/HCM on while on both Dark and Light themes. Red accent color selected in the OS is respected. This resolves this bug as well.

Video of both Light and Dark themes is attached.

Micah [:mtigley] (she/her) - it looks like it is ready for your final review/acceptance, whenever the (patch D139045)[https://phabricator.services.mozilla.com/D139045] is landed.

This looks great! Thank you Dao and Anna for working together on this!

Anna, do you think we can close this?

(In reply to Dão Gottwald [::dao] from comment #20)

Anna, do you think we can close this?

Oh yes, sure! Thank you for following up on that.