Filling as a good first bug to learn workflows.

if (mKeys.size() < 1) {
should use .empty() instead

https://searchfox.org/mozilla-central/rev/489e82dcc1e5afbe691ff3b1c982382914637e38/toolkit/mozapps/update/common/readstrings.cpp#340

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

readstring.cpp:the empty method should be used to check for emptiness instead of the size method.

Hello Sylvestre,
please I would appreciate if you can help me review this.
thanks,
Peggy

Peggy, you already have feedback by bytesized. See:
https://phabricator.services.mozilla.com/D129718#4215456

okay, thank you very much Sylvestre

readstrings.cpp:the empty method should be used to check for emptiness instead of the size method.

Depends on D129751

readstrings.cpp:the empty method shoud be used to check for emptiness instead of the size method.

readstrings.cpp:the empty method should be used to check for emptiness instead of the size method.

Could you please close (abandon) the old reviews ?

(In reply to Sylvestre Ledru [:Sylvestre] from comment #8)

Could you please close (abandon) the old reviews ?

I have done so

https://hg.mozilla.org/mozilla-central/rev/09a7fdf173b4