Closed Bug 1737117 Opened 3 years ago Closed 3 years ago

Apply updates only for `--backgroundtask backgroundupdate`

Categories

(Toolkit :: Application Update, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

(Whiteboard: [fidedi-ope])

Attachments

(2 files)

Right now, any --backgroundtask invocation will process pending updates if it can (namely, when it can take the multi-instance lock). Not restricting made sense when the only background task was backgroundupdate, but less sense when arbitrary short-lived tasks can be sparked.

This ticket tracks makes restricting update processing to backgroundupdate alone.

Severity: -- → S3
Priority: -- → P3
Whiteboard: [fidedi-ope]

I've elected to rename the function from Should... to
ShouldNot..., but not to rename the various test files. The
functionality under test is both "should" and "should not", so I think
the churn of renaming is not justified.

This rearranges the deck chairs to accommodate testing the new
functionality in the next commit.

Assignee: nobody → nalexander
Status: NEW → ASSIGNED

The aim is to avoid background tasks causing unexpected updates, as
happened when we tried to migrate pingsender to a Gecko background
task in Bug 1734262. This commit makes it so that we only process
updates for the backgroundupdate task (and the test-only
shouldprocessupdates task).

Depends on D133556

Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b3be1a6a5e3f Pre: Add a reason to "should process updates at startup" logic. r=bytesized https://hg.mozilla.org/integration/autoland/rev/b78709bc0d0c Only process updates only for `--backgroundtask backgroundupdate`. r=bytesized

Sigh, another Linux-only warnings failure. Green try build at https://treeherder.mozilla.org/jobs?repo=try&revision=a10e8fe4054cb5aee9c5bd8298c9c5b2d42825b6, relanding.

Flags: needinfo?(nalexander)
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3915b16bab4f Pre: Add a reason to "should process updates at startup" logic. r=bytesized https://hg.mozilla.org/integration/autoland/rev/783fd695e32b Only process updates only for `--backgroundtask backgroundupdate`. r=bytesized
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
Blocks: 1746983
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: