CFR doorhanger dropdown regression truncates content
Categories
(Firefox :: Messaging System, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox-esr91 | --- | unaffected |
firefox93 | --- | unaffected |
firefox94 | --- | unaffected |
firefox95 | --- | verified |
People
(Reporter: dmosedale, Assigned: bugzilla)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
Attached is an example. Thanks to Mardak for bisecting; the regression happened in one of these commits. Looking through them, the recent popup link alignment changes from bug 1706534 appear to be the likely trigger; perhaps the hbox/vbox/flex changes in particular.
Steps to reproduce:
- use
about:config
to enablebrowser.newtabpage.activity-stream.asrouter.devtoolsEnabled
- in a new tab, click the wrench icon below the gear icon in the upper right
- search the page content for the word "PERSONAL"
- click the "Show" button to the right of that word
- Once the "Personalized CFR Recommendation" button appears in the URL bar, click it
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 1•3 years ago
|
||
Set release status flags based on info from the regressing bug 1706534
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
The STR didn't work for me, since a console error was printed when I tried to show the message:
JavaScript error: resource://activity-stream/lib/CFRPageActions.jsm, line 339: TypeError: can't access property "attributes", localeStrings is null
but I can trigger the bug by showing the message DOH_ROLLOUT_CONFIRMATION_89
.
Assignee | ||
Comment 4•3 years ago
|
||
This reverts one change from 1706534 but does not regress tha bug.
Reporter | ||
Comment 6•3 years ago
|
||
The reproduction issue makes sense, as it depends on a fix to the devtools that I haven't landed. Thanks so much for your help here, Harry!
Comment 7•3 years ago
|
||
bugherder |
Comment 8•3 years ago
|
||
I have verified that this issue is no longer reproducible by following the steps provided in the description using Firefox 95.0b3 en-US, de, fr, it, and RU (Build ID: 20211104185958) on Windows 10 x64, macOS 11.6, and Ubuntu Linux 20.04 x64.
Description
•