Open
Bug 1737867
Opened 3 years ago
Updated 3 years ago
Refactor _fillForm in LoginManagerChild.jsm
Categories
(Toolkit :: Password Manager, task, P3)
Toolkit
Password Manager
Tracking
()
NEW
People
(Reporter: sfoster, Unassigned)
References
(Blocks 1 open bug)
Details
The login which determine if we should attempt to fill a login form with a saved login all lives in LoginManagerChild.jsm, in a method call _fillForm
. Its a long series of decisions and checks, nested ifs etc. that sorely needs refactoring to make the logic clearer.
The function complexity guardrails managed by eslint are currently disabled for this function, and over time it has continued to grow - currently it has a complexity of 74; the (generous) threshold we enforce is 59.
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•