Closed Bug 1738323 Opened 3 years ago Closed 3 years ago

Define schema for configuration file

Categories

(Firefox :: Theme, task, P1)

task
Points:
2

Tracking

()

RESOLVED FIXED
96 Branch
Iteration:
96.1 - Nov 1 - Nov 14
Tracking Status
firefox96 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

(Whiteboard: [fidefe-theme])

Attachments

(1 file, 1 obsolete file)

The configuration file will list the themes and their expiry dates

Blocks: 1738324
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 96.1 - Nov 1 - Nov 14

I opted to define the configuration file as an object in a new JSM rather than as standard JSON. We will need to access this configuration data before UI startup, to read the installed theme from it. As a JSM, we can load it with getLazyModuleGetter and access it synchronously. A JSON file requires us to access it with fetch or IOUtils. We'd have to introduce async code to BuiltInThemes.maybeInstallActiveBuiltInTheme, which would be messy seeing as it runs in a sync context. Even though sync fetch or IOUtils would be fast since the file would be in omni.ja, I still don't want to add sync I/O anywhere near startup.

Attachment #9249119 - Attachment description: Bug 1738323 - Define schema for built-in theme configuration file. r?dao!,standard8 → Bug 1738323 - Define built-in theme configuration file. r?dao!
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83b257ad49e3 Define built-in theme configuration file. r=dao

Backed out for causing mochitest failures on BuiltInThemeConfig.jsm

Flags: needinfo?(htwyford)

Depends on D130306

Attachment #9250266 - Attachment description: WIP: Bug 1738323 - Part 2 - Add expiry_date property to theme manifests. → Bug 1738323 - Part 2 - Add expiry_date property to theme manifests. r?rpl!,dao
Attachment #9250266 - Attachment is obsolete: true
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e425f12545a Define built-in theme configuration file. r=dao
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Flags: needinfo?(htwyford)
Blocks: 1762260
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: