Define schema for configuration file
Categories
(Firefox :: Theme, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox96 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
(Whiteboard: [fidefe-theme])
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
The configuration file will list the themes and their expiry dates
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
I opted to define the configuration file as an object in a new JSM rather than as standard JSON. We will need to access this configuration data before UI startup, to read the installed theme from it. As a JSM, we can load it with getLazyModuleGetter and access it synchronously. A JSON file requires us to access it with fetch or IOUtils. We'd have to introduce async code to BuiltInThemes.maybeInstallActiveBuiltInTheme, which would be messy seeing as it runs in a sync context. Even though sync fetch or IOUtils would be fast since the file would be in omni.ja, I still don't want to add sync I/O anywhere near startup.
Updated•3 years ago
|
Comment 3•3 years ago
|
||
Backed out for causing mochitest failures on BuiltInThemeConfig.jsm
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D130306
Updated•3 years ago
|
Updated•3 years ago
|
Comment 6•3 years ago
|
||
bugherder |
Assignee | ||
Updated•3 years ago
|
Description
•