Closed Bug 1738325 Opened 3 years ago Closed 3 years ago

Write function that checks for expired themes on a timer

Categories

(Firefox :: Theme, task, P1)

task
Points:
3

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

(Whiteboard: [fidefe-theme])

Attachments

(2 files)

Once daily should be sufficient. Expiry is also low-priority, so it can be heavily deferred. This will need automated tests.

Whiteboard: [fidefe-theme]

This patch allows us to uninstall expired themes. It includes the uninstall logic in BuiltInThemes.ensureBuiltInThemes(), which runs on idle after startup and when about:addons is opened. It also changes aboutaddons.js so we don't show a blank Colorways section in about:addons if there are none installed. Finally, I removed the hidden pref gate controlling the Colorways feature. I initially included that to account for the possibility that we wouldn't finish the feature in time for 94 and we would've needed to uplift a simple patch to disable the dfeature. Since the feature has now shipped, there is no longer a need for the pref.

After colorways expire, the user gets to keep the one they had installed going into the expiry, if any. This is information that would usually be associated with the profile. However, the themes are built-in (i.e. not in the profile). I get around this by saving a list of retained themes in a pref. This has drawbacks, such as making it possible to recover expired themes in about:config. I ran this by Product, and they're okay with it.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Attachment #9249504 - Attachment description: Bug 1738325 - Uninstall expired themes from BuiltInThemes.jsm. r?dao! → WIP: Bug 1738325 - Uninstall expired themes from BuiltInThemes.jsm. r?dao!
Attachment #9249504 - Attachment description: WIP: Bug 1738325 - Uninstall expired themes from BuiltInThemes.jsm. r?dao! → Bug 1738325 - Uninstall expired themes from BuiltInThemes.jsm. r?dao!
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/81b4750bca5d Uninstall expired themes from BuiltInThemes.jsm. r=dao https://hg.mozilla.org/integration/autoland/rev/665778c397d4 Part 2 - Show expired but retained themes among the regular themes in about:addons. r=rpl,dao
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Blocks: 1762260
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: