Supporting inlining through inlinable natives when called from JSOp::FunCall. This helps for patterns like Object.prototype.toString.call(thing).

Add InlinableNativeCallInfo to hold the per function call relevant information.

The next parts of this patch stack will convert the existing functions to use
InlinableNativeCallInfo. The last part will use InlinableNativeCallInfo to
pass the call information from JSOp::FunCall calls.

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags to use InlinableNativeCallInfo.

Depends on D129903

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129904

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129905

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129906

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129907

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129908

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129909

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129910

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129911

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129912

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129913

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129914

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129915

Replaces the accesses to argc_, args_, callee_, newTarget_, and the
CallFlags.

Depends on D129916

Depends on D129917

To support inlining natives through JSOp::FunCall, we now just have to fill in
InlinableNativeCallInfo with the original this-value removed.

Depends on D129918

Hi Jan,
I've added some patches to show how we could easily inline through JSOp::FunCall for inlinable functions. The patches are still marked as WIP, because they're lacking tests and I wanted to check with you first if you think that this approach looks sensible.

(In reply to André Bargull [:anba] from comment #18)

Hi Jan,
I've added some patches to show how we could easily inline through JSOp::FunCall for inlinable functions. The patches are still marked as WIP, because they're lacking tests and I wanted to check with you first if you think that this approach looks sensible.

Nice, this makes sense to me.

It would be good if argc_, args_, callee_, newTarget_ were no longer accessible. What if we move tryAttachMathAbs etc to a new class that contains the fields in InlinableNativeCallInfo + the writer and some other things?

InlinableNativeIRGenerator copies all relevant member fields from CallIRGenerator
only to keep the diff is small. The next patches will remove the pc_, script_,
op_, and isFirstStub_ members.

Use the existing flags_ member field instead of recomputing CallFlags.
This also allows to remove the pc_ member.

Depends on D132125

Change isFirstStub_ and script_ to methods which delegate to CallIRGenerator.

Depends on D132126

When the op_ member is used to detect new- and spread-calls, replace it
with calling CallFlags methods. The other only remaining use is to detect
JSOp::CallIgnoresRv. Replace that one with a method which delegates to
CallIRGenerator.

Depends on D132127

Pass CallFlags to fix the "TODO" note.

Depends on D132128

The callee is guaranteed to be a JSFunction, so we can use HandleFunction
instead of HandleValue.

Depends on D132129

emitNativeCalleeGuard() can just read the callee from the member field instead
of receiving it as a parameter.

Depends on D132130

This parameter is mostly no longer needed. The only remaining methods which used
this parameter were:

• tryAttachMathRandom()
• tryAttachArrayConstructor()
• tryAttachTypedArrayConstructor()

All three methods can use the callee_ member field to access the callee function.

Depends on D132131

This is in preparation for the next part, where we don't want to call
setInputOperandId() for JSOp::FunCall calls.

Depends on D132132

The stack layout is already in the correct format for all Function.prototype.call
calls with more than zero arguments, so we can simply call InlinableNativeIRGenerator
to inline natives. Only two adjustments were needed:

1. writer.setInputOperandId(0) mustn't be called a second time.
2. emitNativeCalleeGuard() mustn't emit the callee guard a second time.

We also cheat a bit: Because we don't guard the callee in emitNativeCalleeGuard()
and thanks to bug 1656469, we don't have to adjust GetIndexOfArgument() to handle
CallFlags::FunCall.

Depends on D132133

(In reply to Jan de Mooij [:jandem] from comment #19)

It would be good if argc_, args_, callee_, newTarget_ were no longer accessible. What if we move tryAttachMathAbs etc to a new class that contains the fields in InlinableNativeCallInfo + the writer and some other things?

I've uploaded another patch set with the proposed design.

(In reply to André Bargull [:anba] [back from break; working through mail backlog] from comment #30)

(In reply to Jan de Mooij [:jandem] from comment #19)

It would be good if argc_, args_, callee_, newTarget_ were no longer accessible. What if we move tryAttachMathAbs etc to a new class that contains the fields in InlinableNativeCallInfo + the writer and some other things?

I've uploaded another patch set with the proposed design.

NI in case you've missed the updates.

(In reply to André Bargull [:anba] [back from break; working through mail backlog] from comment #31)

I've uploaded another patch set with the proposed design.

NI in case you've missed the updates.

I skimmed some of the patches and this looks great!

Note that JSOp::FunCall no longer exists (bug 1760989), but I don't think that really affects these changes.

(In reply to Jan de Mooij [:jandem] from comment #32)

I skimmed some of the patches and this looks great!

Yay!

Note that JSOp::FunCall no longer exists (bug 1760989), but I don't think that really affects these changes.

Yes, no changes were needed. All patches even still apply cleanly on central!

https://hg.mozilla.org/mozilla-central/rev/a01bac0bae2b
https://hg.mozilla.org/mozilla-central/rev/b892b6743a0e
https://hg.mozilla.org/mozilla-central/rev/db6d5a84f079
https://hg.mozilla.org/mozilla-central/rev/1e71f02ed6fd
https://hg.mozilla.org/mozilla-central/rev/3f22f4b57103
https://hg.mozilla.org/mozilla-central/rev/935b2b91d4bb
https://hg.mozilla.org/mozilla-central/rev/41437de94eb4
https://hg.mozilla.org/mozilla-central/rev/df647f3952c2
https://hg.mozilla.org/mozilla-central/rev/6d94cb999968
https://hg.mozilla.org/mozilla-central/rev/3d5b7428d113