Closed Bug 1738482 Opened 3 years ago Closed 3 years ago

[x11] Dragging tab shows partial screenshot

Categories

(Core :: Widget: Gtk, defect, P3)

Product:
Core
Component:
Widget: Gtk
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- unaffected
firefox94 --- unaffected
firefox95 --- disabled
firefox96 --- verified

People

(Reporter: evilpie, Assigned: stransky)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(3 files)

about:support
(deleted), text/plain
Details
Screenshot from 2021-10-29 20-13-37.png
(deleted), image/png
Details
Bug 1738482 [Linux] Force-resize mShell container for D&D popups, r?jhorak
(deleted), text/x-phabricator-request
Details

Since Bug 1730533 dragging a tab now shows a screenshot of the page. Before I just got a paper/document icon. However the drag image seems to be just a partial screenshot of the page, which looks strange.

Attached file about:support (deleted) —

Look at the tiny image (over the w of Hacker News). It seems to be just the upper left corner of the page.

Blocks: linuxdad
Priority: -- → P3

You're right. Can you try to use mozregresison to find wrong commit? I'm sure it worked ok.

Even in 68 we were using the document icon. Older versions of Firefox just crash for me. I bisected the change from icon to partial screenshot to bug 1730533.

Will look at it, Thanks.

Assignee: nobody → stransky

Yes, I see it. This is X11 bug only, works as expected on Wayland...so it's reasons I haven't seen it.

status-firefox93: --- → unaffected
status-firefox94: --- → unaffected
status-firefox95: --- → affected
status-firefox-esr78: --- → unaffected
status-firefox-esr91: --- → unaffected
Keywords: regression
Summary: Dragging tab shows partial screenshot → [x11] Dragging tab shows partial screenshot

DND window is placed inside container so we need to make hard size
request to ensure parent container is resized too.

Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/02baaad3124c [Linux] Force-resize mShell container for D&D popups, r=jhorak

https://hg.mozilla.org/mozilla-central/rev/02baaad3124c

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(stransky)

Verfied fixed, thanks! But there a remaining bug: Every time it's plain white at first and then the image appears.

This is disabled on 95.

status-firefox95: affected → disabled
Flags: needinfo?(stransky)

(In reply to Darkspirit from comment #11)

Verfied fixed, thanks! But there a remaining bug: Every time it's plain white at first and then the image appears.

That's X11 or Wayland?

Flags: needinfo?(jan)

Gnome Xwayland, Debian Testing, Intel
I will start using MOZ_ENABLE_WAYLAND when it is enabled not only on stable (Fedora/Ubuntu), but also on Nightly. :P

Flags: needinfo?(jan)
Depends on: 1740897

(In reply to Darkspirit from comment #14)

Gnome Xwayland, Debian Testing, Intel
I will start using MOZ_ENABLE_WAYLAND when it is enabled not only on stable (Fedora/Ubuntu), but also on Nightly. :P

Filed as Bug 1740897, Thanks.

Flags: qe-verify+

Based on comment 11 I will mark the bug flags accordingly.

Status: RESOLVED → VERIFIED
status-firefox96: fixed → verified
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: