Closed
Bug 1738678
Opened 3 years ago
Closed 3 years ago
Remove unnecessary warning rules on sjs files
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox96 fixed)
RESOLVED
FIXED
96 Branch
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In bug 1576768 we turned on ESLint for sjs files, and made a bunch of existing failures into warnings.
However, when I reviewed it, I neglected to notice that we'd turned on too many rules globally for sjs files - some rules are enabled for certain areas of the code, but for sjs files they were turned on (as warnings) everywhere.
This currently gives us ~3400 extra warnings, which I don't think is necessary as we're not currently planning on turning those rules on everywhere, and if/when we do we can handle them appropriately.
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6dc14faae982
Remove unnecessary ESLint warning rules for sjs files. r=Gijs
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•