Closed
Bug 1739168
Opened 3 years ago
Closed 3 years ago
Prevent NotFoundError logspam on new profiles startup due to PermissionStore maybeMigrateData still checking e.becauseNoSuchFile
Categories
(WebExtensions :: General, defect, P3)
Tracking
(firefox96 fixed)
RESOLVED
FIXED
96 Branch
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: rpl, Assigned: rpl)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
It looks we missed this one while migrating ExtensionPermissions.jsm away from osfile.jsm helpers as part of Bug 1735132.
It is not a big deal because:
- it is just a warning message that wasn't supposed to be logged under those condition (the
extension-preferences.jsonfile being missing and so nothing would have been needed to be migrated anyway) - at the moment PermissionStore.maybeMigrateData is only going to be called when the rkv-based permission store is being used, which at the moment is only the case in Nightly (at least until we are enabling it on all channels, tracked by Bug 1646182)
Nevertheless, that check is never going to be true now that ExtensionPermissions.jsm is not using osfile.jsm and so we should fix it to match the same kind of check we are doing elsewhere (!(e instanceof DOMException && e.name == "NotFoundError").
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/e3ba47447d0b
Fix PermissionStore maybeMigrateData check for 'file not found' errors. r=Standard8
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•