Search dropdown in about:newtab is not dark in dark mode with browser.newtabpage.activity-stream.improvesearch.handoffToAwesomebar set to false
Categories
(Firefox :: New Tab Page, defect, P5)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox94 | --- | wontfix |
firefox95 | --- | wontfix |
firefox96 | --- | verified |
People
(Reporter: Fanolian+BMO, Assigned: onuohamiriam44, Mentored)
References
(Regression)
Details
(Keywords: regression, reproducible, Whiteboard: [lang=css])
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:96.0) Gecko/20100101 Firefox/96.0
Build ID: 20211104094642
Steps to reproduce
- In a new profile, set
browser.newtabpage.activity-stream.improvesearch.handoffToAwesomebar
to false. - Set Nightly theme to dark, or other Colorways themes that default to dark. (OS light/dark mode is irrelevant.)
- In about:newtab, type
a
in the search bar at the middle of the newtab page.
Actual result
The search suggestion dropdown is not dark. Please see the attached screenshot.
Expected result
The dropdown is dark.
Regression
Last good Nightly: 2021-09-16
First bad Nightly: 2021-09-17
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4f9a1f599b43c1748edf0ce1b42a25b5f825db7e&tochange=186467330eb16b1e6ac6c7b2b3794f5b5cdc5341
This is regressed by bug 1727319.
Credit
This is originally reported by deviltrombone on Reddit.
Comment 1•3 years ago
|
||
browser.newtabpage.activity-stream.improvesearch.handoffToAwesomebar: false
is not a supported configuration, so this isn't a priority. I'm marking this as a P5 since we could accept a community or mentored patch. The changes that removed dark mode support are here. A fix would need to re-add styles in _Search.scss
using the variables available in _theme.scss. The styles were removed since the new colors introduced in that patch didn't produce sufficient contrast. There may be some other way to structure the variables that have sufficient contrast. Refer to the Firefox Home build docs for instructions on how to compile newtab CSS.
Assignee | ||
Comment 2•3 years ago
|
||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
Hello Harry, please can you review the patch. Thank you..
Comment 4•3 years ago
|
||
Set release status flags based on info from the regressing bug 1727319
Assignee | ||
Comment 5•3 years ago
|
||
Hi Harry, I have made the changes, can you please review it again? Thank you.
Assignee | ||
Comment 6•3 years ago
|
||
Hello Harry, I have made the changes. Can you please review it again. Thank you.
Assignee | ||
Comment 7•3 years ago
|
||
I have removed the fill color. Can you check it out again? Thank you.
Comment 8•3 years ago
|
||
Hi Miriam, there's no need to post on Bugzilla when you make changes. I get emails from Phabricator when you update your patch there.
Updated•3 years ago
|
Comment 10•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Comment 11•3 years ago
|
||
I have verified that the issue is no longer reproducible by following the steps provided in the description using Firefox Beta 96.0b2 (20211207185904) on Windows 10 x64, macOS 11.6, and Ubuntu Linux 20.04 x64.
Description
•