Closed
Bug 1739666
Opened 3 years ago
Closed 3 years ago
Messaging system should use feature.variables.enabled, not feature.enabled
Categories
(Firefox :: Nimbus Desktop Client, defect, P1)
Firefox
Nimbus Desktop Client
Tracking
()
RESOLVED
FIXED
96 Branch
People
(Reporter: k88hudson, Assigned: andreio)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
|
Details |
After deprecating .enabled in experimenter, we discovered messaging system is still using the old property. We should update it to use feature.variables.enabled
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Attachment #9249768 -
Attachment description: WIP: Bug 1739666 - Messaging system should use feature.variables.enabled, not feature.enabled → Bug 1739666 - Messaging system should use feature.variables.enabled, not feature.enabled
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b04b4f5c324d
Messaging system should use feature.variables.enabled, not feature.enabled r=k88hudson
Comment 3•3 years ago
|
||
Backed out for newtab failures. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/792b7fca03f5398f64042cbd9070c38cd6100f9b
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=357646210&repo=autoland&lineNumber=388
Flags: needinfo?(andrei.br92)
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b13c1db634c
Messaging system should use feature.variables.enabled, not feature.enabled r=k88hudson
Comment 5•3 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Assignee | ||
Comment 6•3 years ago
|
||
Comment on attachment 9249768 [details]
Bug 1739666 - Messaging system should use feature.variables.enabled, not feature.enabled
Beta/Release Uplift Approval Request
- User impact if declined: We want this change as part of the TCP rollout experiment bug 1731713 for Firefox 95.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): We have tests covering this change and this has been verified by QA as part of the testing for bug 1738206 (comment 14).
- String changes made/needed:
Flags: needinfo?(andrei.br92)
Attachment #9249768 -
Flags: approval-mozilla-beta?
Comment 7•3 years ago
|
||
Comment on attachment 9249768 [details]
Bug 1739666 - Messaging system should use feature.variables.enabled, not feature.enabled
Approved for 95.0b6
Attachment #9249768 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•3 years ago
|
||
bugherder uplift |
status-firefox95:
--- → fixed
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•