moz-lwtheme* pseudo-classes don't get invalidated correctly
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox96 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(5 files)
I found this while investigating the failures bug 1740089 caused. Probably also fixes bug 1737131.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
This I noticed while working on the following patches. Shouldn't have
any behavior change: the behavior does in fact match the element state
flag semantics correctly if we do this. We did split the dir flags into
two element bits a while ago.
:not(:dir()) still behaves correctly of course, and we have tests for that.
Assignee | ||
Comment 2•3 years ago
|
||
Use the same document state mechanism we have for :moz-locale-dir. Also,
simplify the setup of the later to be the same as :dir(), allowing the
matching code to be less repetitive.
This should fix some flakiness in chrome mochitests, but we have no existing
tests for these pseudo-classes more generally and since they're just
chrome-only I'm not super-excited about adding more.
Depends on D130734
Assignee | ||
Comment 3•3 years ago
|
||
Behind a pref for now. Given these selectors do nothing on non-chrome
documents (they just don't match) it seems worth trying.
A cursory search seems to indicate they're not used for UA detection or
something like that (or at least I haven't found such an usage).
Depends on D130735
Assignee | ||
Comment 4•3 years ago
|
||
And remove code for :-moz-submit-invalid completely.
Depends on D130736
Assignee | ||
Comment 8•3 years ago
|
||
Without this some tests fail with the previous patch because code like:
starts throwing. Unfortunately I had missed that on my try run, because
the error message didn't include that exception (it seemed like an
intermittent browser-chrome failure instead).
We could expose a ChromeOnly API for this, but this seems better. This
fixes it trivially, and also removes the "no url data" situation from
the selector parser, which is nice.
Comment 10•3 years ago
|
||
Backed out for causing build bustages.
Backout link: https://hg.mozilla.org/integration/autoland/rev/248823d9b8df67f62f2b126a463bfa01c7c0b9c5
Failure log:
bustage - https://treeherder.mozilla.org/logviewer?job_id=357576885&repo=autoland&lineNumber=40070
failures before the patch - https://treeherder.mozilla.org/logviewer?job_id=357577922&repo=autoland&lineNumber=6210
- https://treeherder.mozilla.org/logviewer?job_id=357575845&repo=autoland&lineNumber=86847
Updated•3 years ago
|
Comment 11•3 years ago
|
||
The last 2 patches were backed out, but the first 2 were merged to central:
https://hg.mozilla.org/mozilla-central/rev/4176f472e85a
https://hg.mozilla.org/mozilla-central/rev/e76b53d685ee
Comment 12•3 years ago
|
||
Comment 13•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Comment 14•3 years ago
|
||
Comment 15•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/09cdd8f9b238
https://hg.mozilla.org/mozilla-central/rev/6a6251c65131
https://hg.mozilla.org/mozilla-central/rev/67a281174487
Description
•