Closed
Bug 1740627
Opened 3 years ago
Closed 3 years ago
Reinstate BaseThreadInitThunk hook
Categories
(Core :: DLL Services, enhancement)
Tracking
()
RESOLVED
FIXED
96 Branch
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: toshi, Assigned: toshi)
References
(Depends on 1 open bug)
Details
Crash Data
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We have a number of crashes on BaseThreadInitThunk where a new thread tried to execute an invalid address. Some of them could be prevented by reinstating the BaseThreadInitThunk hook. Currently we use it only when the launcher process is disabled or in plugin-container.exe.
|
Assignee | |
Updated•3 years ago
|
Crash Signature: [@ BaseThreadInitThunk ]
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
We have the protection mechanism to protect BaseThreadInitThunk. After we
released the launcher process, however, this hook is activated if the launcher
process is disabled, or in plugin-container.exe. Hopefully this hook still
helps reduce the crash at BaseThreadInitThunk.
The patch moves the code applying the hook in DllBlocklist_Initialize to
make it run before the init flag check.
Pushed by tkikuchi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36e2b3fafc78
Reinstate BaseThreadInitThunk hook. r=mhowell
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Crash Signature: [@ BaseThreadInitThunk ] → [@ BaseThreadInitThunk ]
[@ @0x0 | BaseThreadInitThunk]
You need to log in
before you can comment on or make changes to this bug.
Description
•