Closed Bug 1740788 Opened 3 years ago Closed 3 years ago

[dark theme] Regression: Focussed Tab height has become smaller

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Platform:
Desktop
All
Type:
defect
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Iteration:
96.2 - Nov 15 - Nov 28
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox94 --- unaffected
firefox95 --- unaffected
firefox96 --- fixed

People

(Reporter: mehmet.sahin, Assigned: dao)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Nightly_vs_Stable.png
(deleted), image/png
Details
Bug 1740788 - Set background-origin on the selected tab's background, clean up how we set the border, and make the box-shadow full black so it works correctly on different backgrounds. r=harry
(deleted), text/x-phabricator-request
Details
Attached image Nightly_vs_Stable.png (deleted) —

Nightly 96.0a1 (2021-11-11) (64-Bit)
macOS 12.0.1

Steps to reproduce:
1.) Open a New Tab in FF Nightly
2.) Compare the height of the Tab in FF Nightly with FF Stable

Actual: In FF Nightly the Tab height has become smaller.

Expected: They should be higher to match again the with the height of Hover Botton of the New Tab Button.

This is a regression in recent Nightly.

A screenshot Nightly vs Stable is attached.

Thanks for fixing in advance.

If the new height of the tabs is intended, then please also adjust size of the New Tab Hover Button. Also, please also adjust then the curving of the tabs. They do not look so nicely curved as before. Thanks.

This issue only affects the focussed tab. The hover buttons of the Tabs and New Tab Button look fine.

Summary: Regression: Tab height has become smaller → Regression: Focussed Tab height has become smaller

I found the Regression Range:

Good Build: 2021-11-01-08-46-51-mozilla-central/

Bad Build: 2021-11-01-21-59-26-mozilla-central/

Please, who can help to find the culprit CL between this range?

Thanks in advance.

Doesn't seem to happen on Windows for me (at least at 150% dpi) so perhaps related to bug 1738855?

Regressed by: 1734128
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1738855
Summary: Regression: Focussed Tab height has become smaller → [macOS] Regression: Focussed Tab height has become smaller
Has Regression Range: --- → yes

(In reply to :Gijs (he/him) from comment #5)

Doesn't seem to happen on Windows for me (at least at 150% dpi) so perhaps related to bug 1738855?

Err, no, sorry, this happens on Windows too, but only on the dark theme.

OS: Unspecified → All
Hardware: Unspecified → Desktop
Summary: [macOS] Regression: Focussed Tab height has become smaller → [dark theme] Regression: Focussed Tab height has become smaller

Set release status flags based on info from the regressing bug 1734128

status-firefox94: --- → unaffected
status-firefox95: --- → unaffected
status-firefox-esr91: --- → unaffected
Assignee: nobody → dao+bmo
Severity: -- → S2
Status: NEW → ASSIGNED
Iteration: --- → 96.2 - Nov 15 - Nov 28
Points: --- → 2
Priority: -- → P1
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/965bf155a9db Set background-origin on the selected tab's background, clean up how we set the border, and make the box-shadow full black so it works correctly on different backgrounds. r=harry
Blocks: 1742119

https://hg.mozilla.org/mozilla-central/rev/965bf155a9db

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox96: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Regressions: 1742462
Regressions: 1746000
Regressions: 1742239
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: