Closed Bug 174146 Opened 22 years ago Closed 21 years ago

Clean up toolbar css

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
minor

Tracking

()

RESOLVED INVALID

People

(Reporter: kerz, Assigned: kerz)

References

Details

Attachments

(2 files)

This bug is to clean up the toolbar css. This includes moving the generic rules into toolkit, and simplifying rules. It also has the side effect of makeing text only mode look nicer, and fixing the smallicon/text mode.
Attached patch browser.css changes (deleted) — Splinter Review
A few comments. (1) We need to decide if Phoenix is eventually going to use moz-appearance for toolbarbuttons. The Orbit skin forces us to remove the appearance because of the "circular" buttons. I'm not convinced that this is a change we want to enact at the toolkit level, especially since you will kill rollovers for things like the close box, the chevron, and other non-circular objects that look good with the rollover even in Orbit. (2) I would expect the menubutton dropmarker to show up even in text only mode. Otherwise folder buttons will be indistinguishable from leaf buttons. I don't think of the menubutton droparrow as an image/icon. (3) You left moz-appearance for dual menubuttons on UNIX? That doesn't make sense to me. Why would we be different on UNIX? This situation is basically a mess because we aren't using the toolbar style that we'd like (i.e., normal non-circular buttons).
What is this change to: min-width: 0; max-width: 13em; padding: 2px 3px; - color: black !important; + -moz-box-orient: horizontal; and why is it being done in a skin file?
Severity: normal → minor
Blocks: 189043
I don't think this is relevant anymore. Correct me if I'm wrong.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → INVALID
Taking QA Contact
QA Contact: asa → bugzilla
QA Contact: bugzilla → toolbars
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: