+++ This bug was initially created as a clone of Bug #1741559 +++

+++ This bug was initially created as a clone of Bug #1739784 +++

Change URI APIs to from raw string to smart string. Patch in progress.

This patch shows that if you touch it, it easily spins out of control. There are some APIs left which pass the URI as a string, most notably GetMsgDBHdrFromURI() which can't be changed without further ripple effects to nsMsgDBFolder::OnMessageClassified(). There is also quite a bit of ugliness around nsMsgCompose::CreateMessage().

Please do a try run with the patch.

Sorry, one tweak more.

This overlaps with the list on bug 1739814, so adding a blocking dependency.

Sorry, wrong bug number.

ESR 91 version:
https://github.com/Betterbird/thunderbird-patches/blob/main/91/bugs/1741619-string-APIs.patch

Try: https://treeherder.mozilla.org/jobs?repo=try-comm-central&selectedTaskRun=O4lY01lVQfmXSCwSaTds_A.0&revision=9128fd6b5391d709dbb779349796ff940b3ee8d6

Thanks. We shipped it in our fork to fix bug 1739814 comment #3. Feel free to review the patch over there, too. It needs clang-formatting (which sadly can't be done on mailnews/ as a whole since it will modify other files). Also please note the ESR versions here and in the other bug.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/eba00963c6a0
Change most URI APIs to from raw string to smart string. r=mkmelin

Comment on attachment 9251327 [details] [diff] [review]
1741619-string-APIs.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1571672
User impact if declined: Various things don't work on folders with non-ASCII names: Saves multiple drafts, virtual folders don't work, etc.
Testing completed (on c-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky):
Not risky, mostly mechanical change of raw string API to "smart" string API allowing for non-ASCII strings to be correctly passed around.
Part of a pack of four bugs which need to be uplifted in this order:
Bug 1741559, bug 1741619, bug 1739814, bug 1739903. Bug 1739784 was the first one in the series and that's already on ESR.

Comment on attachment 9251327 [details] [diff] [review]
1741619-string-APIs.patch

[Triage Comment]
Approved for beta

Thunderbird 95.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/b3408bdba5bf

Comment on attachment 9251327 [details] [diff] [review]
1741619-string-APIs.patch

[Triage Comment]
Approved for esr91

Thunderbird 91.4.1:
https://hg.mozilla.org/releases/comm-esr91/rev/8217ca8f959e