Closed
Bug 1741666
Opened 3 years ago
Closed 3 years ago
Don't rely on global look-and-feel-changed notification in ToolbarIconColor.
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
96 Branch
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
It might fire before styles are invalidated, so it might cache the wrong style. This is causing failures with the patch in bug 1740089, since after that patch browser_ext_browserAction_theme_icons trigger the theme changes when switching from dark to default mode or similar.
|
Assignee | |
Comment 1•3 years ago
|
||
It might fire before styles are invalidated, so it might cache the wrong
styles.
Instead, fire an event on the window once everything in that window has
been invalidated, not just the global theme.
This is causing failures with the patch in bug 1740089, since after that
patch browser_ext_browserAction_theme_icons trigger the theme changes
when switching from dark to default mode or similar.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc530589bb35
Don't rely on global look-and-feel-changed notification in ToolbarIconColor. r=Gijs
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•