Add an option to show only the extension's errors in about:debugging
Categories
(DevTools :: about:debugging, defect, P3)
Tracking
(firefox-esr91 unaffected, firefox94 unaffected, firefox95 unaffected, firefox96 wontfix, firefox97 fixed, firefox98 verified)
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox94 | --- | unaffected |
firefox95 | --- | unaffected |
firefox96 | --- | wontfix |
firefox97 | --- | fixed |
firefox98 | --- | verified |
People
(Reporter: petr.laskevic, Assigned: ochameau)
References
Details
(Keywords: regression)
Attachments
(5 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:94.0) Gecko/20100101 Firefox/94.0
Steps to reproduce:
Install an extension (addon) from addons.mozilla.org
Notice it doesn't work (this was my addon so I'm curious why)
Open about:debugging
Select expect on my extension to view errors
Actual results:
I get totally lost when there are 20 other addons all showing their logs and errors.
Expected results:
There is a checkbox to only view errors of the inspected extension, so I find relevant logs and errors fast
Comment 1•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Toolkit::Add-ons Manager' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
Reporter | ||
Updated•3 years ago
|
Comment 2•3 years ago
|
||
Thanks for logging, could you share some of the addons you use in your profile so that we can reproduce the bug?
Comment 3•3 years ago
|
||
:ochameau looked at the code, and we apparently don't filter errors coming from other extensions at all. Should be reproducible with any extension then.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
The original report isn't against Nightly and so is before bug 1675456 landed.
It means that on current release, we are still going throught the WebConsole actor
and use ConsoleServiceListener, which isn't filtering anything:
this.window is null because targetActor.isRootActor=true:
https://searchfox.org/mozilla-central/rev/65d4d3399afa79c8de5a0cc11752d2ba7c31edc1/devtools/server/actors/webconsole/listeners/console-service.js#72-102)
=> on release we log all exception, like the MBT.
Whereas on Nightly, bug 1675456 kicks in and we are going using ErrorMessageWatcher.
This time, this class filter out everything, so that we never log any error.
Or may be the one related to the top-most browser window.
Long story short, this class doesn't support WebExtension codepath.
This patch addresses the watcher class codepath. Only tests should be using the console actor and ConsoleServiceListener.
Updated•3 years ago
|
Comment 5•3 years ago
|
||
Set release status flags based on info from the regressing bug 1675456
Assignee | ||
Comment 6•3 years ago
|
||
See previous changeset.
Assignee | ||
Comment 7•3 years ago
|
||
Assignee | ||
Comment 8•3 years ago
|
||
This will be used in following changeset to better identify docshells related to the add-on.
Assignee | ||
Comment 9•3 years ago
|
||
We were iterating over all parent process docshells...
so debugging one web extension would probably have side effects on the whole browser
instead of only the web extension itself!
It is a bit hard to cover this with a test as that's some server side only data,
but the following patch and test only works with this being fixed.
Assignee | ||
Comment 10•3 years ago
|
||
Comment 11•3 years ago
|
||
Updated•3 years ago
|
Comment 12•3 years ago
|
||
Is this something we are targeting for 96 or now 97 based on comment 4? thank you!
Comment 13•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2a6147885938
https://hg.mozilla.org/mozilla-central/rev/b530b0c4f4c7
https://hg.mozilla.org/mozilla-central/rev/ce5f81f38c5b
https://hg.mozilla.org/mozilla-central/rev/74d153fe3e84
Assignee | ||
Comment 14•3 years ago
|
||
(In reply to Dianna Smith [:diannaS] from comment #12)
Is this something we are targeting for 96 or now 97 based on comment 4? thank you!
We can target 97.
I actually rephrase my changeset comment on phabricator and this isn't reflected on bugzilla.
I was wrong in comment 4, bug 1675456 actually improved things significantly. These was still a small edgecase that I'm fixing here.
Updated•3 years ago
|
Updated•3 years ago
|
Comment 15•3 years ago
|
||
I tried to reproduce this issue on Win10x64 using builds 96.0a1 and 94.0a1(20210906214243), but with no luck, can you please mention what addons did you use? (I tried emoji, Notefox: Websites notes, uBlock Origin, ScrollAnywhere).
Is the issue still reproducing on your side on latest 97.0? Thank you.
Reporter | ||
Comment 16•3 years ago
|
||
(In reply to Monica Chiorean from comment #15)
I tried to reproduce this issue on Win10x64 using builds 96.0a1 and 94.0a1(20210906214243), but with no luck, can you please mention what addons did you use? (I tried emoji, Notefox: Websites notes, uBlock Origin, ScrollAnywhere).
Is the issue still reproducing on your side on latest 97.0? Thank you.
I can reproduce it on release version 95.0. On Nightly version 98.0a1 it has been fixed. I use Dark Reader, Save Page WE and more addons. The more addons you install the more likely you will see their errors
Comment 17•3 years ago
|
||
(In reply to petr.laskevic from comment #16)
(In reply to Monica Chiorean from comment #15)
I tried to reproduce this issue on Win10x64 using builds 96.0a1 and 94.0a1(20210906214243), but with no luck, can you please mention what addons did you use? (I tried emoji, Notefox: Websites notes, uBlock Origin, ScrollAnywhere).
Is the issue still reproducing on your side on latest 97.0? Thank you.I can reproduce it on release version 95.0. On Nightly version 98.0a1 it has been fixed. I use Dark Reader, Save Page WE and more addons. The more addons you install the more likely you will see their errors
Fix is included on Nightly version 98.0a1 and Beta 97.0 so that is why it not reproducing. Issues exist on 95.0 because it does not have the fix. Marking as verified based on comment#16.
Description
•