Closed Bug 1741808 Opened 3 years ago Closed 3 years ago

Enable devtools.every-frame-target.enabled on Nightly

Categories

(DevTools :: Framework, task)

task

Tracking

(firefox96 fixed)

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(2 files, 4 obsolete files)

Let's have this bake in Nightly for a bit so we can get feedback

Depends on D131476

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a091d9b9bee6
[devtools] Fix increased failures on browser_toolbox_backward_forward_navigation.js when EFT is enabled. r=ochameau.

oh shoot, I forgot I attached the test fixes to this bug when landing them

Keywords: leave-open

We were always using the top level walker front, but as some tests are using iframes,
we need to use the node fronts dedicated walker front instead.
test_inspector-dead-nodes.html is purely skipped when EFT is enabled as it triggers
failures more frequently and it doesn't make much sense anyway (this test will be
migrated to a command test when we move walkerFront#children to a command).

Depends on D131598

Since we're going to enable EFT on Nightly and let it bake there a bit to
get feedback, we might face a situation where we have to disable EFT.
Having these test variants will help us to not regress non-EFT cases so if
we ever have to rollback EFT, there wouldn't be extra work.

Depends on D131477

Depends on: 1742107
Attachment #9251544 - Attachment description: Bug 1741808 - [devtools] Fix server chrome inspector test when EFT is enabled. r=bomsy. → Bug 1741808 - [devtools] Fix server chrome inspector test when EFT is enabled. r=ochameau.
Depends on: 1742329
Depends on: 1742330
Depends on: 1742331
Blocks: 1742332

Comment on attachment 9251317 [details]
Bug 1741808 - [devtools] Make browser_resources_document_events.js handle EFT. r=ochameau.

Revision D131476 was moved to bug 1742330. Setting attachment 9251317 [details] to obsolete.

Attachment #9251317 - Attachment is obsolete: true

Comment on attachment 9251543 [details]
Bug 1741808 - [devtools] Fix more frequent failures on browser_dbg-event-breakpoints-fission.js when EFT is enabled. r=bomsy.

Revision D131598 was moved to bug 1742331. Setting attachment 9251543 [details] to obsolete.

Attachment #9251543 - Attachment is obsolete: true

Comment on attachment 9251544 [details]
Bug 1741808 - [devtools] Fix server chrome inspector test when EFT is enabled. r=ochameau.

Revision D131599 was moved to bug 1742329. Setting attachment 9251544 [details] to obsolete.

Attachment #9251544 - Attachment is obsolete: true

Comment on attachment 9251545 [details]
Bug 1741808 - Enable devtools no eft config. r=jdescottes.

Revision D131600 was moved to bug 1742332. Setting attachment 9251545 [details] to obsolete.

Attachment #9251545 - Attachment is obsolete: true
Depends on: 1742541
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f637151059d
[devtools] Enable EFT on Nightly. r=bomsy.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: leave-open
Resolution: --- → FIXED

Backed out for causing damp failures.

Flags: needinfo?(nchevobbe)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Filed Bug 1742800 for this failure

Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/810cfde65f6f
[devtools] Enable EFT on Nightly. r=bomsy.
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Regressions: 1746952
Regressions: 1755266
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: